chore(ddtrace/tracer): ensure test coverage for Dogstatsd setup

DataDog · Nov 22, 2024 · 3e7b5f7 · 3e7b5f7
1 parent 1d37913
commit 3e7b5f7
Showing 1 changed file with 48 additions and 4 deletions.
diff --git a/ddtrace/tracer/option_test.go b/ddtrace/tracer/option_test.go
@@ -451,6 +451,14 @@ func TestTracerOptionsDefaults(t *testing.T) {
 
 	t.Run("dogstatsd", func(t *testing.T) {
 		t.Run("default", func(t *testing.T) {
+			tracer := newTracer(WithAgentTimeout(2))
+			defer tracer.Stop()
+			c := tracer.config
+			assert.Equal(t, c.dogstatsdAddr, "localhost:8125")
+			assert.Equal(t, globalconfig.DogstatsdAddr(), "localhost:8125")
+		})
+
+		t.Run("default:ignore", func(t *testing.T) {
 			tracer := newTracer(WithAgentTimeout(2), withIgnoreAgent(true))
 			defer tracer.Stop()
 			c := tracer.config
@@ -459,6 +467,15 @@ func TestTracerOptionsDefaults(t *testing.T) {
 		})
 
 		t.Run("env-host", func(t *testing.T) {
+			t.Setenv("DD_AGENT_HOST", "my-host")
+			tracer := newTracer(WithAgentTimeout(2))
+			defer tracer.Stop()
+			c := tracer.config
+			assert.Equal(t, c.dogstatsdAddr, "my-host:8125")
+			assert.Equal(t, globalconfig.DogstatsdAddr(), "my-host:8125")
+		})
+
+		t.Run("env-host:ignore", func(t *testing.T) {
 			t.Setenv("DD_AGENT_HOST", "my-host")
 			tracer := newTracer(WithAgentTimeout(2), withIgnoreAgent(true))
 			defer tracer.Stop()
@@ -468,6 +485,15 @@ func TestTracerOptionsDefaults(t *testing.T) {
 		})
 
 		t.Run("env-port", func(t *testing.T) {
+			t.Setenv("DD_DOGSTATSD_PORT", "123")
+			tracer := newTracer(WithAgentTimeout(2))
+			defer tracer.Stop()
+			c := tracer.config
+			assert.Equal(t, "localhost:8125", c.dogstatsdAddr)
+			assert.Equal(t, "localhost:8125", globalconfig.DogstatsdAddr())
+		})
+
+		t.Run("env-port:ignore", func(t *testing.T) {
 			t.Setenv("DD_DOGSTATSD_PORT", "123")
 			tracer := newTracer(WithAgentTimeout(2), withIgnoreAgent(true))
 			defer tracer.Stop()
@@ -479,29 +505,47 @@ func TestTracerOptionsDefaults(t *testing.T) {
 		t.Run("env-both", func(t *testing.T) {
 			t.Setenv("DD_AGENT_HOST", "my-host")
 			t.Setenv("DD_DOGSTATSD_PORT", "123")
-			tracer := newTracer(WithAgentTimeout(2), withIgnoreAgent(true))
+			tracer := newTracer(WithAgentTimeout(2))
 			defer tracer.Stop()
 			c := tracer.config
 			assert.Equal(t, c.dogstatsdAddr, "my-host:123")
 			assert.Equal(t, globalconfig.DogstatsdAddr(), "my-host:123")
 		})
 
-		t.Run("env-env", func(t *testing.T) {
-			t.Setenv("DD_ENV", "testEnv")
+		t.Run("env-both:ignore", func(t *testing.T) {
+			t.Setenv("DD_AGENT_HOST", "my-host")
+			t.Setenv("DD_DOGSTATSD_PORT", "123")
 			tracer := newTracer(WithAgentTimeout(2), withIgnoreAgent(true))
 			defer tracer.Stop()
 			c := tracer.config
-			assert.Equal(t, "testEnv", c.env)
+			assert.Equal(t, c.dogstatsdAddr, "my-host:123")
+			assert.Equal(t, globalconfig.DogstatsdAddr(), "my-host:123")
 		})
 
 		t.Run("option", func(t *testing.T) {
+			tracer := newTracer(WithDogstatsdAddress("10.1.0.12:4002"))
+			defer tracer.Stop()
+			c := tracer.config
+			assert.Equal(t, c.dogstatsdAddr, "10.1.0.12:8125")
+			assert.Equal(t, globalconfig.DogstatsdAddr(), "10.1.0.12:8125")
+		})
+
+		t.Run("option:ignore", func(t *testing.T) {
 			tracer := newTracer(WithDogstatsdAddress("10.1.0.12:4002"), withIgnoreAgent(true))
 			defer tracer.Stop()
 			c := tracer.config
 			assert.Equal(t, c.dogstatsdAddr, "10.1.0.12:4002")
 			assert.Equal(t, globalconfig.DogstatsdAddr(), "10.1.0.12:4002")
 		})
 
+		t.Run("env-env", func(t *testing.T) {
+			t.Setenv("DD_ENV", "testEnv")
+			tracer := newTracer(WithAgentTimeout(2))
+			defer tracer.Stop()
+			c := tracer.config
+			assert.Equal(t, "testEnv", c.env)
+		})
+
 		t.Run("uds", func(t *testing.T) {
 			assert := assert.New(t)
 			dir, err := os.MkdirTemp("", "socket")