Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiler] Fix Profiler execution benchmark tests #6652

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[Profiler] Fix Profiler execution benchmark tests #6652

merged 1 commit into from
Feb 11, 2025

Conversation

gleocadie
Copy link
Collaborator

Summary of changes

Fix profiler execution benchmark tests.

Reason for change

The Http profiling feature added the benchmark test but the VMs do not exist. This prevent the job from running.

Implementation details

Remove the http benchmark tests until the vms are created.

Test coverage

Other details

@gleocadie gleocadie requested a review from a team as a code owner February 11, 2025 09:24
@github-actions github-actions bot added area:builds project files, build scripts, pipelines, versioning, releases, packages area:profiler Issues related to the continous-profiler labels Feb 11, 2025
andrewlock
andrewlock approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6652) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (70ms)  : 64, 76
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6652) - mean (991ms)  : 968, 1014
     .   : milestone, 991,
    master - mean (994ms)  : 968, 1019
     .   : milestone, 994,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6652) - mean (103ms)  : 100, 105
     .   : milestone, 103,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6652) - mean (674ms)  : 660, 688
     .   : milestone, 674,
    master - mean (675ms)  : 662, 688
     .   : milestone, 675,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6652) - mean (89ms)  : 88, 91
     .   : milestone, 89,
    master - mean (90ms)  : 87, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (6652) - mean (632ms)  : 616, 647
     .   : milestone, 632,
    master - mean (635ms)  : 608, 662
     .   : milestone, 635,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6652) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (190ms)  : 186, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6652) - mean (1,104ms)  : 1069, 1140
     .   : milestone, 1104,
    master - mean (1,104ms)  : 1076, 1131
     .   : milestone, 1104,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6652) - mean (270ms)  : 265, 274
     .   : milestone, 270,
    master - mean (270ms)  : 266, 273
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (6652) - mean (864ms)  : 835, 893
     .   : milestone, 864,
    master - mean (864ms)  : 834, 895
     .   : milestone, 864,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6652) - mean (261ms)  : 257, 265
     .   : milestone, 261,
    master - mean (261ms)  : 257, 266
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (6652) - mean (843ms)  : 812, 873
     .   : milestone, 843,
    master - mean (845ms)  : 814, 877
     .   : milestone, 845,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6652 compared to master:

  • 3 benchmarks are slower, with geometric mean 1.122
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.86μs 37.4ns 191ns 0.0155 0.00777 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10μs 53.3ns 277ns 0.0145 0.00483 0 5.8 KB
master StartStopWithChild net472 15.8μs 35.3ns 132ns 1.03 0.293 0.0952 6.21 KB
#6652 StartStopWithChild net6.0 7.83μs 44ns 282ns 0.0151 0.00754 0 5.6 KB
#6652 StartStopWithChild netcoreapp3.1 10.1μs 57ns 395ns 0.02 0.005 0 5.8 KB
#6652 StartStopWithChild net472 15.9μs 56ns 217ns 1.06 0.339 0.105 6.22 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 519μs 350ns 1.36μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 653μs 607ns 2.27μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 851μs 292ns 1.09μs 0.422 0 0 3.3 KB
#6652 WriteAndFlushEnrichedTraces net6.0 524μs 732ns 2.74μs 0 0 0 2.7 KB
#6652 WriteAndFlushEnrichedTraces netcoreapp3.1 650μs 633ns 2.45μs 0 0 0 2.7 KB
#6652 WriteAndFlushEnrichedTraces net472 842μs 467ns 1.75μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 131μs 529ns 2.05μs 0.132 0 0 14.47 KB
master SendRequest netcoreapp3.1 150μs 238ns 920ns 0.226 0 0 17.27 KB
master SendRequest net472 0.00515ns 0.00186ns 0.00721ns 0 0 0 0 b
#6652 SendRequest net6.0 128μs 406ns 1.57μs 0.192 0 0 14.47 KB
#6652 SendRequest netcoreapp3.1 143μs 330ns 1.28μs 0.212 0 0 17.27 KB
#6652 SendRequest net472 0.00137ns 0.000534ns 0.00207ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6652

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.46 KB 41.68 KB 222 B 0.54%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 591μs 3.09μs 16μs 0.631 0 0 41.46 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 658μs 3.12μs 11.7μs 0.355 0 0 41.75 KB
master WriteAndFlushEnrichedTraces net472 851μs 3.13μs 12.1μs 8.81 2.52 0.419 53.32 KB
#6652 WriteAndFlushEnrichedTraces net6.0 578μs 2.87μs 12.5μs 0.556 0 0 41.68 KB
#6652 WriteAndFlushEnrichedTraces netcoreapp3.1 669μs 3.67μs 22μs 0.359 0 0 41.67 KB
#6652 WriteAndFlushEnrichedTraces net472 873μs 4.44μs 20.4μs 8.33 2.5 0.417 53.39 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.33μs 2.62ns 10.1ns 0.0146 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 3.43ns 13.3ns 0.0129 0 0 1.02 KB
master ExecuteNonQuery net472 2.15μs 2.1ns 7.84ns 0.156 0.00107 0 987 B
#6652 ExecuteNonQuery net6.0 1.35μs 1.73ns 6.72ns 0.0141 0 0 1.02 KB
#6652 ExecuteNonQuery netcoreapp3.1 1.78μs 5.83ns 22.6ns 0.0134 0 0 1.02 KB
#6652 ExecuteNonQuery net472 2.06μs 1.64ns 6.37ns 0.156 0.00102 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.28μs 0.527ns 2.04ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.58μs 0.729ns 2.73ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.66μs 1.78ns 6.89ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.22μs 0.825ns 3.2ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.65μs 2.08ns 8.06ns 0.0138 0 0 1.02 KB
master CallElasticsearchAsync net472 2.64μs 1.2ns 4.48ns 0.166 0 0 1.05 KB
#6652 CallElasticsearch net6.0 1.19μs 0.802ns 2.78ns 0.0138 0 0 976 B
#6652 CallElasticsearch netcoreapp3.1 1.52μs 0.83ns 3.21ns 0.013 0 0 976 B
#6652 CallElasticsearch net472 2.53μs 0.978ns 3.79ns 0.158 0 0 995 B
#6652 CallElasticsearchAsync net6.0 1.31μs 0.433ns 1.68ns 0.0137 0 0 952 B
#6652 CallElasticsearchAsync netcoreapp3.1 1.67μs 2.08ns 8.04ns 0.0133 0 0 1.02 KB
#6652 CallElasticsearchAsync net472 2.59μs 1.42ns 5.5ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.3μs 0.677ns 2.62ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.64μs 0.678ns 2.63ns 0.0123 0 0 952 B
master ExecuteAsync net472 1.87μs 0.755ns 2.93ns 0.145 0 0 915 B
#6652 ExecuteAsync net6.0 1.37μs 0.763ns 2.64ns 0.013 0 0 952 B
#6652 ExecuteAsync netcoreapp3.1 1.66μs 1.84ns 6.9ns 0.0123 0 0 952 B
#6652 ExecuteAsync net472 1.9μs 0.706ns 2.64ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.51μs 2.1ns 7.85ns 0.0312 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.35μs 1.63ns 6.33ns 0.0374 0 0 2.85 KB
master SendAsync net472 7.46μs 2.18ns 8.46ns 0.493 0 0 3.12 KB
#6652 SendAsync net6.0 4.36μs 3.56ns 13.8ns 0.0329 0 0 2.31 KB
#6652 SendAsync netcoreapp3.1 5.35μs 2.44ns 9.44ns 0.0373 0 0 2.85 KB
#6652 SendAsync net472 7.45μs 2.79ns 10.8ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.51μs 0.417ns 1.56ns 0.0227 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.25μs 0.478ns 1.66ns 0.0227 0 0 1.64 KB
master EnrichedLog net472 2.54μs 1.02ns 3.97ns 0.249 0 0 1.57 KB
#6652 EnrichedLog net6.0 1.54μs 1.29ns 4.83ns 0.023 0 0 1.64 KB
#6652 EnrichedLog netcoreapp3.1 2.24μs 1.64ns 6.12ns 0.0222 0 0 1.64 KB
#6652 EnrichedLog net472 2.56μs 0.671ns 2.32ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 130ns 487ns 0.0559 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 116μs 191ns 741ns 0 0 0 4.28 KB
master EnrichedLog net472 151μs 84.5ns 327ns 0.674 0.225 0 4.46 KB
#6652 EnrichedLog net6.0 112μs 94.9ns 367ns 0.0554 0 0 4.28 KB
#6652 EnrichedLog netcoreapp3.1 118μs 194ns 750ns 0.0585 0 0 4.28 KB
#6652 EnrichedLog net472 150μs 176ns 682ns 0.68 0.227 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3μs 1.37ns 5.32ns 0.0299 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.28μs 2.96ns 11.5ns 0.0297 0 0 2.2 KB
master EnrichedLog net472 4.97μs 1.79ns 6.92ns 0.32 0 0 2.02 KB
#6652 EnrichedLog net6.0 3.03μs 1.22ns 4.55ns 0.0305 0 0 2.2 KB
#6652 EnrichedLog netcoreapp3.1 4.09μs 4.49ns 17.4ns 0.0308 0 0 2.2 KB
#6652 EnrichedLog net472 4.96μs 1.51ns 5.86ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6652

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.120 1,979.32 2,216.93

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.29μs 1.22ns 4.73ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.71μs 2.64ns 10.2ns 0.0155 0 0 1.14 KB
master SendReceive net472 1.98μs 1.68ns 6.49ns 0.183 0 0 1.16 KB
#6652 SendReceive net6.0 1.34μs 0.555ns 2.15ns 0.0161 0 0 1.14 KB
#6652 SendReceive netcoreapp3.1 1.78μs 0.958ns 3.45ns 0.015 0 0 1.14 KB
#6652 SendReceive net472 2.22μs 1.33ns 5.14ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.76μs 1.18ns 4.55ns 0.0221 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.91μs 3.11ns 12.1ns 0.0215 0 0 1.65 KB
master EnrichedLog net472 4.39μs 1.99ns 6.89ns 0.322 0 0 2.04 KB
#6652 EnrichedLog net6.0 2.69μs 2.97ns 11.5ns 0.0215 0 0 1.6 KB
#6652 EnrichedLog netcoreapp3.1 3.89μs 1.05ns 3.77ns 0.0216 0 0 1.65 KB
#6652 EnrichedLog net472 4.34μs 2.38ns 9.23ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6652

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.125 547.10 615.26
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 1.121 805.13 902.74

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 482ns 0.868ns 3.36ns 0.00798 0 0 576 B
master StartFinishSpan netcoreapp3.1 547ns 0.762ns 2.85ns 0.00786 0 0 576 B
master StartFinishSpan net472 630ns 1.17ns 4.54ns 0.0918 0 0 578 B
master StartFinishScope net6.0 575ns 0.882ns 3.42ns 0.00966 0 0 696 B
master StartFinishScope netcoreapp3.1 669ns 0.458ns 1.71ns 0.0093 0 0 696 B
master StartFinishScope net472 805ns 1.48ns 5.75ns 0.105 0 0 658 B
#6652 StartFinishSpan net6.0 467ns 0.627ns 2.43ns 0.00796 0 0 576 B
#6652 StartFinishSpan netcoreapp3.1 616ns 0.467ns 1.81ns 0.00797 0 0 576 B
#6652 StartFinishSpan net472 580ns 0.942ns 3.65ns 0.0918 0 0 578 B
#6652 StartFinishScope net6.0 557ns 0.968ns 3.75ns 0.0096 0 0 696 B
#6652 StartFinishScope netcoreapp3.1 704ns 0.999ns 3.87ns 0.00945 0 0 696 B
#6652 StartFinishScope net472 903ns 1.09ns 4.06ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 650ns 0.737ns 2.85ns 0.00982 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 984ns 1.68ns 6.49ns 0.00924 0 0 696 B
master RunOnMethodBegin net472 1.01μs 2.88ns 11.2ns 0.105 0 0 658 B
#6652 RunOnMethodBegin net6.0 685ns 0.767ns 2.97ns 0.00962 0 0 696 B
#6652 RunOnMethodBegin netcoreapp3.1 990ns 1.01ns 3.92ns 0.00948 0 0 696 B
#6652 RunOnMethodBegin net472 1.07μs 1.82ns 7.06ns 0.104 0 0 658 B

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Feb 11, 2025 •
edited
Loading

Datadog Report

Branch report: gleocadie/fix-profiler-execution-benchmark-tests
Commit report: f95763c
Test service: dd-trace-dotnet

✅ 0 Failed, 250601 Passed, 2416 Skipped, 18h 51m 1.14s Total Time

@andrewlock andrewlock merged commit 07844c3 into master Feb 11, 2025
139 of 141 checks passed
@andrewlock andrewlock deleted the gleocadie/fix-profiler-execution-benchmark-tests branch February 11, 2025 16:55
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:profiler Issues related to the continous-profiler
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gleocadie @andrewlock