Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2341 Expose server date provider interface #950

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

maxep
Copy link
Member

@maxep maxep commented Jul 29, 2022

What and why?

Expose clock synchronisation interface to allow custom implementation.

How?

ServerDateProvider has now public access level and a custom provider can be injected at configuration. The list of Datadog NTP pools are also expose if needed.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@maxep maxep requested a review from a team as a code owner July 29, 2022 11:13
@maxep maxep self-assigned this Jul 29, 2022
@maxep maxep force-pushed the maxep/RUMM-2341/expose-ntp-interface branch 2 times, most recently from 4b15fee to c8c8c0f Compare July 29, 2022 12:34
@ncreated ncreated force-pushed the maxep/RUMM-2341/expose-ntp-interface branch from c8c8c0f to b8a839c Compare August 2, 2022 11:11
@ncreated
Copy link
Member

ncreated commented Aug 2, 2022

Related to #647

Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@ncreated ncreated merged commit a77d0f2 into develop Aug 2, 2022
@ncreated ncreated deleted the maxep/RUMM-2341/expose-ntp-interface branch August 2, 2022 12:56
@ncreated ncreated mentioned this pull request Aug 3, 2022
6 tasks
This was referenced Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants