RUMM-2299 Split Device Info and Battery Status #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxep
force-pushed
the
maxep/RUMM-2299/datadog-core-context-device
branch
from
e31709e to
619e5f7
Compare
ncreated
approved these changes
Jun 28, 2022
Comment on lines
9
to
10
| /// Describes current device information. | ||
| internal class DeviceInfo { |
There was a problem hiding this comment.
oops, left over from MobileDevice, good catch!
maxep
force-pushed
the
maxep/RUMM-2299/datadog-core-context-device
branch
from
4245ceb to
851dacc
Compare
maxep
force-pushed
the
maxep/RUMM-2299/datadog-core-context-device
branch
from
851dacc to
d2821db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
In preparation of v2 Context, the
BatteryStatusmonitoring is now extracted fromMobileDevice.The
MobileDevicehas been renamed toDeviceInfoas it is not representing mobile specific data.How?
The
BatteryStatusProvidernow hold the the battery monitoring logic.The
DeviceInfois part of the core context and is used to build theRUMDeviceandRUMOperatingSystem.TODOs
Review checklist
Custom CI job configuration (optional)