RUMM-2169 Isolate RUM feature from Core's configuration and dependencies #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use SDK context instead.
ncreated
commented
Jun 2, 2022
Comment on lines
-962
to
-966
| // MARK: - Tracking Consent | ||
|
|
||
| func testWhenChangingConsentValues_itUploadsOnlyAuthorizedRUMEvents() throws { | ||
| let consentProvider = ConsentProvider(initialConsent: .pending) | ||
|
|
There was a problem hiding this comment.
Same as in logging PR - consent aware uploads a no longer responsibility of Feature so we can't test it here.
6 tasks
Base automatically changed from
ncreated/RUMM-2169-isolate-tracing-from-core-configuration
to
feature/v2
June 3, 2022 11:04
maxep
approved these changes
Jun 3, 2022
ncreated
deleted the
ncreated/RUMM-2169-isolate-RUM-from-core-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
🔨🧰 A counterpart of #877 but for the
RUMFeature.How?
Common configuration is now removed from
FeaturesConfiguration.RUM:struct RUM { // ... - let common: Common let uploadURL: URL let applicationID: String let sessionSampler: Sampler // ... }Common dependencies are now removed from
RUMFeatureinterface:internal final class RUMFeature: V1FeatureInitializable { // ... - // MARK: - Dependencies - let sdkInitDate: Date - let dateProvider: DateProvider - let dateCorrector: DateCorrectorType - let appStateListener: AppStateListening - let userInfoProvider: UserInfoProvider - let networkConnectionInfoProvider: NetworkConnectionInfoProviderType - let carrierInfoProvider: CarrierInfoProviderType - let launchTimeProvider: LaunchTimeProviderType - let vitalCPUReader: SamplingBasedVitalReader - let vitalMemoryReader: SamplingBasedVitalReader - let vitalRefreshRateReader: ContinuousVitalReader - let onSessionStart: RUMSessionListener? // ... }🚚 There will be one more PR on this subject which will consolidate all
TODOsand cleanup this new concept. It is only possible now, after all Features are migrated to the new flow.Review checklist
Custom CI job configuration (optional)