Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-2077 Vitals Frequency Configuration #876

Merged
merged 5 commits into from
Jun 7, 2022
Merged

RUMM-2077 Vitals Frequency Configuration #876

merged 5 commits into from
Jun 7, 2022

Conversation

maxep
Copy link
Member

@maxep maxep commented Jun 2, 2022

What and why?

Customers can set the desired delay between Mobile Vitals update (CPU/RAM) as follows:

  • FREQUENT - every 100ms
  • AVERAGE - 500 ms
  • RARE - 1000ms
  • NEVER - don’t provide vitals data

How?

VitalInfoSampler will start the sample timer only if frequency parameter is available.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@maxep maxep marked this pull request as ready for review June 2, 2022 08:10
@maxep maxep requested review from a team as code owners June 2, 2022 08:10
@maxep maxep self-assigned this Jun 2, 2022
@maxep maxep force-pushed the maxep/RUMM-2077/vitals-frequency branch from 5525d86 to d185a9d Compare June 2, 2022 09:00
ncreated
ncreated requested changes Jun 2, 2022
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍, but there's a blocking issue in CHANGELOG.md.

@maxep maxep force-pushed the maxep/RUMM-2077/vitals-frequency branch from d185a9d to b6936c8 Compare June 2, 2022 12:12
@maxep maxep requested a review from ncreated June 2, 2022 14:56
@maxep maxep force-pushed the maxep/RUMM-2077/vitals-frequency branch from a6102a5 to 31db8cd Compare June 3, 2022 09:25
@maxep maxep requested a review from ncreated June 3, 2022 10:57
@maxep maxep force-pushed the maxep/RUMM-2077/vitals-frequency branch from 31db8cd to 7ba289f Compare June 3, 2022 15:51
@maxep maxep marked this pull request as draft June 3, 2022 16:14
@maxep maxep force-pushed the maxep/RUMM-2077/vitals-frequency branch from 7ba289f to cf900c6 Compare June 3, 2022 16:31
@maxep maxep marked this pull request as ready for review June 3, 2022 17:24
maxep
maxep commented Jun 3, 2022
View reviewed changes
Sources/Datadog/RUM/RUMMonitor/Scopes/RUMScopeDependencies.swift
Comment on lines +13 to +18
struct VitalsReaders {
let frequency: TimeInterval
let cpu: SamplingBasedVitalReader
let memory: SamplingBasedVitalReader
let refreshRate: ContinuousVitalReader
}
Copy link
Member Author

@maxep maxep Jun 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new dependency helps instantiating all readers only if frequency is available.

ncreated
ncreated approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👌👌

@maxep maxep merged commit cdc9526 into develop Jun 7, 2022
@maxep maxep deleted the maxep/RUMM-2077/vitals-frequency branch June 7, 2022 07:25
@ncreated ncreated mentioned this pull request Jun 20, 2022
Merged
6 tasks
@ncreated ncreated mentioned this pull request Jul 21, 2022
Merged
6 tasks
This was referenced Sep 16, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

@alai97 alai97 alai97 approved these changes

Assignees

@maxep maxep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxep @ncreated @alai97