Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-3292 Adds iOS Mobile Vitals Documentation #804

Merged
merged 2 commits into from
May 18, 2022
Merged

DOCS-3292 Adds iOS Mobile Vitals Documentation #804

merged 2 commits into from
May 18, 2022

Conversation

alai97
Copy link
Contributor

@alai97 alai97 commented Apr 5, 2022 •
edited
Loading

What and why?

Adds Mobile Vitals doc page in the iOS SDK repo + removes a Crash Reporting beta banner.

How?

DOCS-3292

Additional Notes

Preview link is available in Documentation PR #13614.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing change.

@alai97 alai97 added the documentation Improvements or additions to documentation label Apr 5, 2022
@alai97 alai97 requested review from a team as code owners April 5, 2022 20:29
@apigirl apigirl added the editorial review Waiting on a more in-depth review from the docs team label Apr 5, 2022
@alai97 alai97 requested a review from charlesbaiden April 6, 2022 01:37
charlesbaiden
charlesbaiden reviewed Apr 6, 2022
View reviewed changes
Copy link

@charlesbaiden charlesbaiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment - thanks!

@alai97 alai97 changed the base branch from develop to master April 6, 2022 16:15
alai97
alai97 commented Apr 6, 2022
View reviewed changes
alai97
alai97 commented Apr 7, 2022
View reviewed changes
Copy link
Contributor Author

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event Timings appears in the side panel with metrics only, graphs appear in Mobile Vitals on the Overview page.

alai97
alai97 commented Apr 8, 2022
View reviewed changes
ncreated
ncreated approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍, I only left one comment on ANRs which don't have a place in iOS. Thx @alai97!

@ncreated ncreated force-pushed the alai97/mobile-vitals-ios-doc-update branch from d31796b to c1f44cf Compare April 11, 2022 17:03
@alai97 alai97 mentioned this pull request May 4, 2022
Closed
6 tasks
@maxep maxep force-pushed the alai97/mobile-vitals-ios-doc-update branch from 1552fb1 to 4407653 Compare May 18, 2022 12:28
@maxep maxep changed the base branch from master to develop May 18, 2022 12:28
@maxep maxep merged commit 43bc54d into develop May 18, 2022
@maxep maxep deleted the alai97/mobile-vitals-ios-doc-update branch May 18, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbaiden charlesbaiden charlesbaiden left review comments

@ncreated ncreated ncreated approved these changes

@maycmlee maycmlee maycmlee approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation editorial review Waiting on a more in-depth review from the docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alai97 @ncreated @maycmlee @charlesbaiden @maxep @apigirl