Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-7435: Add Session Replay startRecordingImmediately ObjC API #2120

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Nov 26, 2024

What and why?

This PR adds missing Session Replay startRecordingImmediately ObjC API.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)

@0xnm 0xnm requested review from a team as code owners November 26, 2024 09:04
@0xnm
Copy link
Member Author

0xnm commented Nov 26, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 26, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-26 09:08:45 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-26 10:00:44 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in develop is 27m.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 26, 2024

Datadog Report

Branch report: nogorodnikov/rum-7435/add-session-replay-startrecordingimmediately-objc-api
Commit report: 974910c
Test service: dd-sdk-ios

✅ 0 Failed, 3554 Passed, 0 Skipped, 3m 43.67s Total Time
🔻 Test Sessions change in coverage: 3 decreased, 3 increased, 8 no change

🔻 Code Coverage Decreases vs Default Branch (3)

  • test DatadogInternalTests tvOS 80.4% (-0.02%) - Details
  • test DatadogCrashReportingTests iOS 26.63% (-0.02%) - Details
  • test DatadogInternalTests iOS 80.38% (-0.02%) - Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants