Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4079 chore: Migrate E2E Tests app workflow to GitLab #1957

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Jul 11, 2024

What and why?

πŸ“¦ 🧰 This PR migrates E2E Tests workflow to GitLab (build β†’ sign β†’ upload to synthetics). It follows other GitLab migration efforts: #1953, #1945, #1921 and #1910.

The only remaining automation in Bitrise is ❌ Dogfooding. It will be migrated next.

How?

This work is leveraging existing code-sign.sh flow. Previous script was renamed and modularized with enhanced errors handling. It now creates all code-signing files (certificate, provisioning profile, and xcconfig) from CI secrets and delegates archive, export and upload routines to E2ETests/Makefile as before.

🎁 Extra elements:

  • Runner.ipa is also deployed as CI job artifact (stored for short retention)
  • DRY_RUN env is supported for local development and testing (does all but the s8s upload)

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Session Replay

@ncreated ncreated requested review from a team as code owners July 11, 2024 12:59
@ncreated ncreated self-assigned this Jul 11, 2024
maxep
maxep previously approved these changes Jul 12, 2024
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I love the new pattern :)

@ncreated ncreated force-pushed the ncreated/RUM-4079/migrate-e2e-s8s-upload branch from 7b28498 to e2aa865 Compare July 16, 2024 06:50
@ncreated ncreated merged commit 56d50a1 into develop Jul 16, 2024
17 checks passed
@ncreated ncreated deleted the ncreated/RUM-4079/migrate-e2e-s8s-upload branch July 17, 2024 09:19
@ncreated ncreated mentioned this pull request Jul 25, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants