Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disable flaky OTelSpan.testSetActive_givenParentSpan() test for tvOS #1884

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Jun 5, 2024

What and why?

📦 Same as #1881 but for tvOS.

How?

Disabling flaky test for tvOS target.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ncreated ncreated self-assigned this Jun 5, 2024
@ncreated ncreated requested review from a team as code owners June 5, 2024 14:30
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 5, 2024

Datadog Report

Branch report: ncreated/chore/disable-flaky-OTel-tests-for-tvOS
Commit report: 3200a0c
Test service: dd-sdk-ios

✅ 0 Failed, 3234 Passed, 0 Skipped, 2m 39.5s Total Time
🔻 Test Sessions change in coverage: 6 decreased, 3 increased, 4 no change

🔻 Code Coverage Decreases vs Default Branch (6)

This report shows up to 5 code coverage decreases.

  • test DatadogTraceTests tvOS 54.92% (-0.2%) - Details
  • test DatadogRUMTests tvOS 81.4% (-0.08%) - Details
  • test DatadogCoreTests iOS 73.91% (-0.06%) - Details
  • test DatadogTraceTests iOS 54.63% (-0.03%) - Details
  • test DatadogCrashReportingTests tvOS 27.3% (-0.02%) - Details

@ncreated ncreated merged commit 35f7ae3 into develop Jun 6, 2024
8 checks passed
@ncreated ncreated deleted the ncreated/chore/disable-flaky-OTel-tests-for-tvOS branch June 6, 2024 13:35
This was referenced Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants