Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4632 Use global session-replay configuration in webview tracking #1879

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Jun 4, 2024

What and why?

Use the Session Replay masking when enabling WebView Tracking.

How?

Allow retrieving any type from the core's feature registry and share the SessionReplayConfiguration protocol definition so it can be read from WebView tracking.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maxep maxep requested review from a team as code owners June 4, 2024 12:12
func get<T>(feature type: T.Type) -> T? where T: DatadogFeature
func feature<T>(named name: String, type: T.Type) -> T?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This was the original signature, it allows retrieving any type from the core.

@maxep maxep force-pushed the maxep/RUM-4632/sr-weview-config branch from 71e5a5d to add1619 Compare June 4, 2024 12:15
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 4, 2024

Datadog Report

Branch report: maxep/RUM-4632/sr-weview-config
Commit report: bc65793
Test service: dd-sdk-ios

✅ 0 Failed, 3235 Passed, 0 Skipped, 2m 35.32s Total Time
🔻 Test Sessions change in coverage: 8 decreased, 5 increased

🔻 Code Coverage Decreases vs Default Branch (8)

This report shows up to 5 code coverage decreases.

  • test DatadogRUMTests tvOS 81.37% (-0.13%) - Details
  • test DatadogCrashReportingTests iOS 27.24% (-0.12%) - Details
  • test DatadogRUMTests iOS 81.35% (-0.11%) - Details
  • test DatadogTraceTests iOS 55.19% (-0.11%) - Details
  • test DatadogCrashReportingTests tvOS 27.3% (-0.1%) - Details

@maxep maxep force-pushed the maxep/RUM-4632/sr-weview-config branch 3 times, most recently from 1b6c205 to c3ef65b Compare June 4, 2024 12:58
@maxep maxep force-pushed the maxep/RUM-4632/sr-weview-config branch from bf821f0 to c669cd1 Compare June 4, 2024 14:48
@maxep maxep merged commit 1581030 into develop Jun 11, 2024
10 checks passed
@maxep maxep deleted the maxep/RUM-4632/sr-weview-config branch June 11, 2024 08:59
@maciejburda maciejburda mentioned this pull request Jun 12, 2024
8 tasks
@ncreated ncreated mentioned this pull request Jun 13, 2024
8 tasks
@maciejburda maciejburda mentioned this pull request Jun 13, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants