Fix GH asset otel validation #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariedm
previously approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Is this script executed automatically as part of a CI/CD pipeline or other workflow?
There was a problem hiding this comment.
It's part of CD pipeline and executed when distributing a new tag 👍
| name = 'OpenTelemetryApi.xcframework' | ||
|
|
||
| def validate(self, zip_directory: DirectoryMatcher, in_version: Version) -> bool: | ||
| min_otel_version = Version('2.12.0') |
There was a problem hiding this comment.
nit: this could be added at the top of the file with the other version requirements (though it's only used by this function for now)
There was a problem hiding this comment.
This min version only applies to otel, so it can be contained in OpenTelemetryXCFrameworkValidator. We can make it global when we need to share it 👍
mariedm
approved these changes
Jun 4, 2024
ncreated
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Validate
OpenTelemetryApi.xcframeworkduring distribution.Review checklist
Custom CI job configuration (optional)
tools/