RUM-917 Improve telemetry of type mismatch #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejburda
force-pushed
the
maciey/RUM-917/wireframe-type-mismatch
branch
from
5f3af49 to
d6ff2b3
Compare
Datadog ReportBranch report: ✅ 0 Failed, 253 Passed, 0 Skipped, 13.51s Total Time |
mariedm
approved these changes
Jun 4, 2024
| } | ||
|
|
||
| // MARK: - Resolving Mutations | ||
|
|
||
| internal typealias WireframeMutation = SRIncrementalSnapshotRecord.Data.MutationData.Updates | ||
|
|
||
| internal enum WireframeMutationError: Error { | ||
| internal enum WireframeMutationError: Error, Equatable { |
There was a problem hiding this comment.
I believe this enum is automatically conforming to Equatable since the associated values you added are String. I don't think it's an issue to add it explicitly, but I was wondering if I missed anything here?
There was a problem hiding this comment.
Assertions in test were complaining about it. I think that once enum has associated values it needs to be explicitly specified
maxep
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Adds extra telemetry info to to help resolving type mismatch error in Session Replay.
How?
Expands error type to contain from and to types of the wireframe that conflicted.
Review checklist
Custom CI job configuration (optional)
tools/