Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DatadogSessionReplay to the Swift API surface generation #1804

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Apr 29, 2024

What and why?

This PR adds DatadogSessionReplay to the Swift API surface generation.

One thing which comes from this PR is that since DatadogSessionReplay also contains some Objective-C bindings, they leak into Swift API surface file. But to address this changes are needed in generation logic, it seems.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@0xnm 0xnm requested review from a team as code owners April 29, 2024 09:36
@0xnm 0xnm changed the base branch from nogorodnikov/add-stopinstance-and-isinitialized-to-objc-api to develop April 29, 2024 10:10
@0xnm 0xnm merged commit d38c1cd into develop Apr 29, 2024
2 checks passed
@ganeshnj ganeshnj mentioned this pull request May 2, 2024
8 tasks
@maxep maxep deleted the nogorodnikov/add-session-replay-to-api-generation branch May 6, 2024 15:05
This was referenced May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants