Fix Swift Package Manager warning for Datadog.modulemap

[ejensen]

What and why?

Fix the Swift Package warning for unprocessable files. Issue #1739

How?

Added the modulemap file to the package target's exclusion list.

Review checklist

• Feature or bugfix MUST have appropriate tests (unit, integration)
• Make sure each commit and the PR mention the Issue number or JIRA reference
• Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

• Run unit tests for Core, RUM, Trace, Logs, CR and WVT
• Run unit tests for Session Replay
• Run integration tests
• Run smoke tests
• Run tests for tools/

[maciejburda]

Unfortunately it fails on smoke test for Mac Catalyst:

xcodebuild build -scheme 'App iOS' -project $PATH/dependency-manager-tests/spm/SPMProject.xcodeproj -destination 'platform=macOS,variant=Mac Catalyst'

I'll try to take a deeper look next week, but on the first glance it looks hard to resolve as there's no conditional exclude available.

[ejensen]

Unfortunately it fails on smoke test for Mac Catalyst:

xcodebuild build -scheme 'App iOS' -project $PATH/dependency-manager-tests/spm/SPMProject.xcodeproj -destination 'platform=macOS,variant=Mac Catalyst'

I'll try to take a deeper look next week, but on the first glance it looks hard to resolve as there's no conditional exclude available.

Running that command completes successfully with these changes. The only warning is the following, but it is not new to these changes:

warning: Run script build phase '⚙️ Run linter' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'App iOS' from project 'SPMProject')

The original Swift Package warning detailed in Issue #1739 states the module map is not being processed by the build system since it has no rules that specify how to process the file. This warning is for all platforms including Mac Catalyst. So seems counter-intuitive if the file the build system is warning about and skipping would cause a new build error by explicitly skipping. What is the build error you are encountering when you run the smoke test?

[maciejburda]

Maybe it's CI flakiness. I'll try restarting

[maxep]

Hey @ejensen 👋

I'm closing this in favor of #1746. The modulemap was added a while ago for compatibility with early SPM, it is no longer necessary so we can remove it.

Thanks again for the report and contribution!