Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release/2.8.0 to develop #1733

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Merge release/2.8.0 to develop #1733

merged 2 commits into from
Mar 19, 2024

Conversation

maciejburda
Copy link
Member

What and why?

git-flow: counterpart of #1732

Fix CHANGELOG

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maciejburda maciejburda marked this pull request as ready for review March 19, 2024 16:01
@maciejburda maciejburda requested review from a team as code owners March 19, 2024 16:01
ncreated
ncreated approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 19, 2024 •
edited
Loading

Datadog Report

Branch report: release/2.8.0
Commit report: 121d700
Test service: dd-sdk-ios

✅ 0 Failed, 2584 Passed, 0 Skipped, 5m 40.93s Wall Time
🔻 Test Sessions change in coverage: 4 decreased, 3 increased, 6 no change

🔻 Code Coverage Decreases vs Default Branch (4)

  • test DatadogRUMTests iOS 79.72% (-0.09%) - Details
  • test DatadogRUMTests tvOS 79.84% (-0.07%) - Details
  • test DatadogCrashReportingTests iOS 28.87% (-0.03%) - Details
  • test DatadogTraceTests tvOS 49.71% (-0.03%) - Details

@maciejburda maciejburda merged commit 7a56868 into develop Mar 19, 2024
16 checks passed
@maciejburda maciejburda deleted the release/2.8.0 branch March 19, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciejburda @ncreated