RUM-1197 fix: WebView Events Overwrite #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxep
force-pushed
the
maxep/RUM-1197/fix-webview-events-decoding
branch
from
9011b00 to
c43d376
Compare
Datadog ReportBranch report: ✅ |
maxep
changed the title
maciejburda
approved these changes
Sep 29, 2023
| dd_sesion["plan"] = 1 | ||
| dd["session"] = dd_sesion | ||
| if var dd = event["_dd"] as? JSON, var dd_session = dd["session"] as? [String: Int64] { | ||
| dd_session["plan"] = 1 |
There was a problem hiding this comment.
good catch in the meantime 🙌
ganeshnj
approved these changes
Sep 29, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
#1433 broke Browser SDK event overwrite. The
AnyEncodabledid encoded integers toInt64but the theWebViewEventReceiverwas still expectedIntHow?
As a quick fix and to release as part of
2.3.0, theWebViewEventReceivernow expectInt64. But a more robust solution will be applied todevelop.Review checklist
Custom CI job configuration (optional)
tools/