Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Xcode 13.4 Nightly Tests #1474

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix Xcode 13.4 Nightly Tests #1474

merged 1 commit into from
Sep 14, 2023

Conversation

maciejburda
Copy link
Member

@maciejburda maciejburda commented Sep 14, 2023 •
edited
Loading

What and why?

Fixes compilation issues on Xcode 13.4.x nightly tests.

How?

Older wait() signature requires timeout parameter. This PR adds that.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@maciejburda maciejburda requested a review from a team as a code owner September 14, 2023 10:54
@maciejburda maciejburda changed the title Fix Xcode13.4 Nightly Tests Fix Xcode 13.4 Nightly Tests Sep 14, 2023
ncreated
ncreated approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@maciejburda maciejburda merged commit 402525e into develop Sep 14, 2023
@maciejburda maciejburda deleted the maciey/fix-xcode13.4-nightly-compilation branch September 14, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciejburda @ncreated