RUMM-2972 [SR] Support UISegmentedControl elements in session replay
#1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncreated
commented
Feb 20, 2023
| branch = framer; | ||
| branch = "ship-framer"; |
There was a problem hiding this comment.
Pointing to stable branch in https://github.com/ncreated/Framing/tree/ship-framer - I added basic text alignment options in there, so we can preview SRTextPosition in snapshot tests.
maxep
approved these changes
Feb 21, 2023
Comment on lines
+47
to
+48
| if #available(iOS 15.0, *) { | ||
| return UIColor.tintColor.cgColor |
There was a problem hiding this comment.
Why 15? this one is available since iOS7
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 With this PR we're adding support to
UISegmentedControlelements in session replay.How?
UISegmentRecorderwithUISegmentWireframesBuilderThe slider is constructed with 1 to many wireframes:
If privacy mode
.maskAllis enabled, we obfuscate text and do not build selection wireframe:I also enhanced the way we deal with system colors by introducing
SystemColorsconstruct. It acts as a collection of system colors, which are UI mode dependant (return different values for light- and dark-mode on iOS 13+).Here, an example of segments in dark mode:
Review checklist
Custom CI job configuration (optional)