Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-8673 Update UserInfo API to make id mandatory. #2509

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

maciejburda
Copy link
Member

What does this PR do?

Makes id parameter of setUserInfo() mandatory. Old signature is kept with deprecation warning.

Motivation

Change requested by PA.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@maciejburda maciejburda changed the title RUM-8673 Update UserInfo API to make id mandatory. #2195 RUM-8673 Update UserInfo API to make id mandatory. Feb 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.06%. Comparing base (fe2a4ca) to head (1370ab5).

Files with missing lines Patch % Lines
...ore/src/main/kotlin/com/datadog/android/Datadog.kt 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2509      +/-   ##
===========================================
+ Coverage    70.00%   70.06%   +0.06%     
===========================================
  Files          794      794              
  Lines        29873    29879       +6     
  Branches      4994     4990       -4     
===========================================
+ Hits         20911    20932      +21     
+ Misses        7582     7572      -10     
+ Partials      1380     1375       -5     
Files with missing lines Coverage Δ
...ore/src/main/kotlin/com/datadog/android/Datadog.kt 71.43% <20.00%> (-4.82%) ⬇️

... and 28 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants