Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-8375] View ended instrumentation type attribute support #2504

Merged
merged 5 commits into from
Feb 14, 2025

Conversation

satween
Copy link
Contributor

@satween satween commented Feb 10, 2025

What does this PR do?

Adds support for optional instrumentation_type attributes into view ended telemetry metric.

Motivation

Spec

Previous PR was too big to add this logic, I'd decided to split them into two separate ones

Additional Notes

I noticed that we were using the additionalAttributes map as a container for some local values that shouldn't be passed
directly to the backend, but used to determine some values just before the actual events are sent, so as a side effect of this PR the local attributes logic has been refactored: Added a single place for such attributes and their cleanup.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween satween requested review from a team as code owners February 10, 2025 16:31
jonathanmos
jonathanmos previously approved these changes Feb 12, 2025
ambushwork
ambushwork previously approved these changes Feb 12, 2025
@satween satween dismissed stale reviews from ambushwork and jonathanmos via 90b3684 February 12, 2025 12:50
@satween satween force-pushed the tvaleev/RUM-8375/optinal-telemetry-envent branch 2 times, most recently from 90b3684 to 29321cf Compare February 12, 2025 13:57
@satween satween force-pushed the tvaleev/RUM-8375/optinal-telemetry-envent branch from 29321cf to 333667a Compare February 12, 2025 14:19
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 73.23944% with 19 lines in your changes missing coverage. Please review.

Project coverage is 69.97%. Comparing base (308b80b) to head (b0f79d2).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...nternal/attributes/ViewScopeInstrumentationType.kt 0.00% 7 Missing ⚠️
...d/rum/internal/metric/ViewEndedMetricDispatcher.kt 75.00% 3 Missing and 2 partials ⚠️
...android/core/internal/attributes/LocalAttribute.kt 63.64% 3 Missing and 1 partial ⚠️
.../android/rum/internal/domain/scope/RumViewScope.kt 66.67% 0 Missing and 1 partial ⚠️
...droid/rum/tracking/ActivityViewTrackingStrategy.kt 50.00% 0 Missing and 1 partial ⚠️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 66.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2504      +/-   ##
===========================================
- Coverage    70.11%   69.97%   -0.14%     
===========================================
  Files          792      794       +2     
  Lines        29895    29857      -38     
  Branches      5000     4988      -12     
===========================================
- Hits         20960    20892      -68     
- Misses        7557     7574      +17     
- Partials      1378     1391      +13     
Files with missing lines Coverage Δ
.../android/core/internal/logger/SdkInternalLogger.kt 91.51% <100.00%> (-0.45%) ⬇️
...droid/internal/telemetry/InternalTelemetryEvent.kt 30.00% <ø> (-2.26%) ⬇️
...droid/rum/tracking/FragmentViewTrackingStrategy.kt 86.96% <100.00%> (+1.24%) ⬆️
...oid/rum/tracking/NavigationViewTrackingStrategy.kt 86.96% <100.00%> (+0.59%) ⬆️
...roid/compose/internal/ComposeNavigationObserver.kt 90.48% <100.00%> (-0.43%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 95.29% <66.67%> (+0.51%) ⬆️
...droid/rum/tracking/ActivityViewTrackingStrategy.kt 88.00% <50.00%> (-1.80%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 87.56% <66.67%> (-2.21%) ⬇️
...android/core/internal/attributes/LocalAttribute.kt 63.64% <63.64%> (ø)
...d/rum/internal/metric/ViewEndedMetricDispatcher.kt 90.91% <75.00%> (-5.64%) ⬇️
... and 1 more

... and 28 files with indirect coverage changes

@satween satween force-pushed the tvaleev/RUM-8375/optinal-telemetry-envent branch 3 times, most recently from 5921d69 to ffa1f6c Compare February 13, 2025 18:05
@satween satween force-pushed the tvaleev/RUM-8375/optinal-telemetry-envent branch from ffa1f6c to b0f79d2 Compare February 14, 2025 12:37
@satween satween merged commit dcb1457 into develop Feb 14, 2025
24 checks passed
@satween satween deleted the tvaleev/RUM-8375/optinal-telemetry-envent branch February 14, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants