-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUM-8375] View ended instrumentation type attribute support #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambushwork
previously approved these changes
Feb 11, 2025
features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/tracking/BundleExt.kt
Outdated
Show resolved
Hide resolved
jonathanmos
previously approved these changes
Feb 12, 2025
ambushwork
previously approved these changes
Feb 12, 2025
90b3684
to
29321cf
Compare
29321cf
to
333667a
Compare
5921d69
to
ffa1f6c
Compare
ffa1f6c
to
b0f79d2
Compare
ambushwork
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for optional instrumentation_type attributes into view ended telemetry metric.
Motivation
Spec
Previous PR was too big to add this logic, I'd decided to split them into two separate ones
Additional Notes
I noticed that we were using the additionalAttributes map as a container for some local values that shouldn't be passed
directly to the backend, but used to determine some values just before the actual events are sent, so as a side effect of this PR the local attributes logic has been refactored: Added a single place for such attributes and their cleanup.
Review checklist (to be filled by reviewers)