Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-7809: Update SDK performance doc with Session Replay measurements #2481

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

ambushwork
Copy link
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork force-pushed the yl/sr/update-perf-doc branch 2 times, most recently from 92979f8 to 1b91414 Compare January 10, 2025 10:22
@ambushwork ambushwork marked this pull request as ready for review January 10, 2025 10:25
@ambushwork ambushwork requested review from a team as code owners January 10, 2025 10:25
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@b13f742). Learn more about missing BASE report.
Report is 51 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2481   +/-   ##
==========================================
  Coverage           ?   69.98%           
==========================================
  Files              ?      788           
  Lines              ?    29559           
  Branches           ?     4935           
==========================================
  Hits               ?    20686           
  Misses             ?     7508           
  Partials           ?     1365           

satween
satween previously approved these changes Jan 10, 2025
@brett0000FF brett0000FF self-assigned this Jan 10, 2025
brett0000FF
brett0000FF previously approved these changes Jan 10, 2025
Copy link

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a light courtesy edit on the new content. Feel free to take what you'd like. 😄

the `System Traces` option.

### Scenario corresponding

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Scenario corresponding
### Scenario configuration

jonathanmos
jonathanmos previously approved these changes Jan 13, 2025
xgouchet
xgouchet previously approved these changes Jan 13, 2025
@ambushwork
Copy link
Member Author

@brett0000FF thanks for the review, I've updated the doc based on your comment!

@ambushwork ambushwork merged commit fc254cf into develop Feb 7, 2025
23 checks passed
@ambushwork ambushwork deleted the yl/sr/update-perf-doc branch February 7, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants