RUM-8349: Add support for detekt checks for session replay compose mo…

…dule
DataDog · Feb 18, 2025 · a25b286 · a25b286
1 parent 85637ab
commit a25b286
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -125,6 +125,7 @@ analysis:detekt-custom:
     - ./gradlew :features:dd-sdk-android-rum:customDetektRules
     - ./gradlew :features:dd-sdk-android-session-replay:customDetektRules
     - ./gradlew :features:dd-sdk-android-session-replay-material:customDetektRules
+    - ./gradlew :features:dd-sdk-android-session-replay-compose:customDetektRules
     - ./gradlew :features:dd-sdk-android-trace:customDetektRules
     - ./gradlew :features:dd-sdk-android-trace-otel:customDetektRules
     - ./gradlew :features:dd-sdk-android-webview:customDetektRules

diff --git a/detekt_custom.yml b/detekt_custom.yml
@@ -509,12 +509,14 @@ datadog:
       - "android.graphics.RectF.constructor()"
       - "android.graphics.RectF.width()"
       - "android.graphics.RectF.height()"
+      - "android.graphics.RectF.toRect()"
       # endregion
       # region Androidx APIs
       - "androidx.appcompat.widget.DatadogActionBarContainerAccessor.constructor(androidx.appcompat.widget.ActionBarContainer)"
       - "androidx.appcompat.widget.DatadogActionBarContainerAccessor.getBackgroundDrawable()"
       - "androidx.compose.foundation.interaction.DragInteraction.Start.constructor()"
       - "androidx.compose.foundation.shape.CornerSize.toPx(androidx.compose.ui.geometry.Size, androidx.compose.ui.unit.Density)"
+      - "androidx.compose.runtime.Composition.takeIf(kotlin.Function1)"
       - "androidx.compose.runtime.DisposableEffect(kotlin.Any?, kotlin.Any?, kotlin.Function1)"
       - "androidx.compose.runtime.DisposableEffectScope.onDispose(kotlin.Function0)"
       - "androidx.compose.runtime.LaunchedEffect(kotlin.Any?, kotlin.Any?, kotlin.Any?, kotlin.coroutines.SuspendFunction1)"
@@ -535,10 +537,14 @@ datadog:
       - "androidx.compose.ui.layout.LayoutCoordinates.positionInWindow()"
       - "androidx.compose.ui.layout.LayoutInfo.getModifierInfo()"
       - "androidx.compose.ui.unit.Density(kotlin.Float, kotlin.Float)"
+      - "androidx.compose.ui.geometry.Rect.toAndroidRectF()"
       - "androidx.compose.ui.geometry.Size(kotlin.Float, kotlin.Float)"
       - "androidx.compose.ui.geometry.Size.copy(kotlin.Float, kotlin.Float)"
       - "androidx.compose.ui.semantics.SemanticsConfiguration.firstOrNull(kotlin.Function1)"
+      - "androidx.compose.ui.Modifier.semantics(kotlin.Boolean, kotlin.Function1)"
+      - "androidx.compose.ui.semantics.SemanticsConfiguration.contains(androidx.compose.ui.semantics.SemanticsPropertyKey)"
       - "androidx.compose.ui.semantics.SemanticsConfiguration.getOrNull(androidx.compose.ui.semantics.SemanticsPropertyKey)"
+      - "androidx.compose.ui.semantics.SemanticsPropertyKey.constructor(kotlin.String, kotlin.Function1)"
       - "androidx.compose.ui.text.AnnotatedString.getStringAnnotations(kotlin.Int, kotlin.Int)"
       - "androidx.core.view.GestureDetectorCompat.constructor(android.content.Context, android.view.GestureDetector.OnGestureListener)"
       - "androidx.core.view.GestureDetectorCompat.onTouchEvent(android.view.MotionEvent)"
@@ -895,6 +901,7 @@ datadog:
       - "kotlin.collections.List.findFirstForType(java.lang.Class)"
       - "kotlin.collections.List.firstOrNull()"
       - "kotlin.collections.List.firstOrNull(kotlin.Function1)"
+      - "kotlin.collections.List.firstNotNullOfOrNull(kotlin.Function1)"
       - "kotlin.collections.List.flatMap(kotlin.Function1)"
       - "kotlin.collections.List.flatMap(kotlin.Function1)"
       - "kotlin.collections.List.fold(com.google.gson.JsonArray, kotlin.Function2)"
@@ -914,6 +921,7 @@ datadog:
       - "kotlin.collections.List.lastOrNull()"
       - "kotlin.collections.List.lastOrNull(kotlin.Function1)"
       - "kotlin.collections.List.map(kotlin.Function1)"
+      - "kotlin.collections.List.mapIndexed(kotlin.Function2)"
       - "kotlin.collections.List.mapNotNull(kotlin.Function1)"
       - "kotlin.collections.List.maxOrNull()"
       - "kotlin.collections.List.orEmpty()"
@@ -1145,6 +1153,7 @@ datadog:
       # region Kotlin Primitives
       - "kotlin.Any.constructor()"
       - "kotlin.Any.hashCode()"
+      - "kotlin.Any.takeIf(kotlin.Function1)"
       - "kotlin.Any.toString()"
       - "kotlin.Boolean.hashCode()"
       - "kotlin.Boolean.not()"
@@ -1158,6 +1167,7 @@ datadog:
       - "kotlin.Double.coerceAtMost(kotlin.Double)"
       - "kotlin.Double.isNaN()"
       - "kotlin.Double.pow(kotlin.Int)"
+      - "kotlin.Double.pow(kotlin.Double)"
       - "kotlin.Double.rangeTo(kotlin.Double)"
       - "kotlin.Double.toFloat()"
       - "kotlin.Double.toInt()"
@@ -1194,6 +1204,7 @@ datadog:
       - "kotlin.Number.toLong()"
       - "kotlin.Short.toUShort()"
       - "kotlin.ULong.toLong()"
+      - "kotlin.String.takeIf(kotlin.Function1)"
       - "kotlin.String.toBigIntegerOrNull()"
       - "kotlin.String.trim(kotlin.Function1)"
       - "kotlin.ULong.toDouble()"

diff --git a/features/dd-sdk-android-session-replay-compose/build.gradle.kts b/features/dd-sdk-android-session-replay-compose/build.gradle.kts
@@ -6,6 +6,7 @@
 
 import com.datadog.gradle.config.androidLibraryConfig
 import com.datadog.gradle.config.dependencyUpdateConfig
+import com.datadog.gradle.config.detektCustomConfig
 import com.datadog.gradle.config.javadocConfig
 import com.datadog.gradle.config.junitConfig
 import com.datadog.gradle.config.kotlinConfig
@@ -91,3 +92,8 @@ dependencyUpdateConfig()
 publishingConfig(
     "Session Replay Extension Support for Jetpack Compose."
 )
+detektCustomConfig(
+    ":dd-sdk-android-core",
+    ":dd-sdk-android-internal",
+    ":features:dd-sdk-android-session-replay"
+)