-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CECO-1860][DatadogGenericResource] Add monitor support #1635
Conversation
… (and associated test)
… (and associated test)
…elier/add_generic_resource_monitors
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1635 +/- ##
==========================================
- Coverage 49.49% 49.33% -0.17%
==========================================
Files 218 219 +1
Lines 21244 21314 +70
==========================================
Hits 10515 10515
- Misses 10182 10252 +70
Partials 547 547
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
What does this PR do?
DatadogGenericResource
Motivation
Additional Notes
This is based on refactor introduced in #1634
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Same as #1534 but using the object in Motivation: test the whole lifecycle of the object: create, update, (optionally: update from UI (waiting for the forcesync)), delete
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label