-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleanup] Remove operator reference in /api folder, refactor v2alpha files #1576
Conversation
See this discussion here #1562 (comment). |
v2alpha1/test to pkg/testutils and v2alpha1/datadogagent_default to internal/controller/defaults
9b7ec48
to
2de4baf
Compare
this is a non-functional change and can be merged without approvals from other teams. |
What does this PR do?
Moved:
v2alpha1/utils
fromapi/datadoghq/v2alpha1
to a new directorypkg/constants/
.v2alpha1/test
topkg/testutils
v2alpha1/datadogagent_default
to a new folder,internal/controller/defaults
Motivation
We want to create a new go module for
/api
, so files that are not specific to the CRDs should be moved out of the/api
folder. There are some files in/api
that depended ondatadog-operator/pkg/defaulting
-- this dependency should be removed because a project depending on the/api
module would indirectly depend ondatadog-operator
too.Additional Notes
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Make sure the binary builds and runs as expected. The change is noop.
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label