[datadogpodautoscalers] Add stabilization window to scaling policy #1519
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
==========================================
+ Coverage 48.86% 50.52% +1.65%
==========================================
Files 225 228 +3
Lines 19959 21425 +1466
==========================================
+ Hits 9753 10824 +1071
- Misses 9695 10093 +398
+ Partials 511 508 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 29 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| // +optional | ||
| // +kubebuilder:validation:Minimum=1 | ||
| // +kubebuilder:validation:Maximum=1800 | ||
| // +kubebuilder:default:0 |
There was a problem hiding this comment.
You don't need to set it, it's implicit. Also not sure how it plays with default being outside of Minimum
There was a problem hiding this comment.
Good point, updated the minimum to 0 and removed the default setting!
jennchenn
deleted the
jenn/CASCL-61_implement-horizontal-stabilization
branch
What does this PR do?
Add stabilization window to scaling policy in
DatadogPodAutoscalersCRDMotivation
We want to support stabilizing recommendations and allow users to configure how long they would like the stabilization windows to be.
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel