Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send error message along with error flag #160

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

jonsabados
Copy link
Contributor

What does this PR do?

This sends the error message along with an error flag

Motivation

When running with universal instrumentation on were loosing error messages if lambdas are returning errors, which impacts our ability to debug issues:
image
With this addition the error message is retained:
image

Testing Guidelines

Sabotaged a lambda behind API gateway to reproduce the issue reliably, and then cloned the code, used a replace directive to import the local patched version, deployed and repeated the test (see the attached screenshot). There weren't any unit tests with coverage on the existing case so I did not add any unit testing.

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@jonsabados jonsabados requested a review from a team as a code owner March 6, 2024 16:46
Copy link

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this oversight!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.55%. Comparing base (c3fb2ee) to head (5ec4889).

❗ Current head 5ec4889 differs from pull request most recent head 30d0b1f. Consider uploading reports for the commit 30d0b1f to get more accurate results

Files Patch % Lines
internal/extension/extension.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   80.86%   80.55%   -0.32%     
==========================================
  Files          13       13              
  Lines         904      905       +1     
==========================================
- Hits          731      729       -2     
- Misses        142      145       +3     
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astuyve astuyve merged commit 8470f40 into DataDog:main Mar 6, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants