Split the synthetics request port field into a oneOf #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![api-clients-generation-pipeline[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
api-clients-generation-pipeline
bot
requested a review
from a team
as a code owner
api-clients-generation-pipeline
bot
added
the
changelog/Changed
Comment on lines
+453
to
+455
| if "{{" in r and "}}" in r: | ||
| # workaround to stop matching templated strings | ||
| raise TypeError(f"{x} is not supported type {schema}") |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3107
branch
from
8685775 to
9a79797
Compare
skarimo
approved these changes
Sep 11, 2024
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3107
branch
from
962525a to
58242cf
Compare
api-clients-generation-pipeline
bot
deleted the
datadog-api-spec/generated/3107
branch
github-actions bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
* update formatter to stop matching templated strings in int schemas * Regenerate client from commit 3288a6f0 of spec repo --------- Co-authored-by: Kevin Zou <[email protected]> Co-authored-by: ci.datadog-api-spec <[email protected]> 92128b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#3107
Test branch datadog-api-spec/test/kevinzou/synthetics_port_oneof