Skip to content

Commit

Permalink
Merge master into datadog-api-spec/test/oliver/-apps-2099-app-builder…
Browse files Browse the repository at this point in the history
…-api-documentation
  • Loading branch information
2 parents 948079d + 987ec86 commit 53808ac
Show file tree
Hide file tree
Showing 14 changed files with 53 additions and 24 deletions.
8 changes: 4 additions & 4 deletions .apigentools-info
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2025-01-08 14:02:30.066418",
"spec_repo_commit": "1920836f"
"regenerated": "2025-01-09 22:06:11.503685",
"spec_repo_commit": "8d40e082"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2025-01-08 14:02:30.082176",
"spec_repo_commit": "1920836f"
"regenerated": "2025-01-09 22:06:11.519399",
"spec_repo_commit": "8d40e082"
}
}
}
20 changes: 14 additions & 6 deletions .generator/schemas/v1/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5957,7 +5957,7 @@ components:
- name
type: object
LogsPipelineList:
description: Array of pipeline ID strings.
description: Array of all log pipeline objects configured for the organization.
items:
$ref: '#/components/schemas/LogsPipeline'
type: array
Expand Down Expand Up @@ -28873,7 +28873,7 @@ paths:
- metrics_metadata_write
/api/v1/monitor:
get:
description: Get details about the specified monitor from your organization.
description: Get all monitors from your organization.
operationId: ListMonitors
parameters:
- description: 'When specified, shows additional information about the group
Expand Down Expand Up @@ -28956,6 +28956,7 @@ paths:
content:
application/json:
schema:
description: An array of monitor objects.
items:
$ref: '#/components/schemas/Monitor'
type: array
Expand All @@ -28979,7 +28980,7 @@ paths:
appKeyAuth: []
- AuthZ:
- monitors_read
summary: Get all monitor details
summary: Get all monitors
tags:
- Monitors
x-pagination:
Expand Down Expand Up @@ -36665,10 +36666,17 @@ tags:
end times, prevent all alerting related to specified Datadog tags.'
name: Downtimes
- description: 'The Event Management API allows you to programmatically post events
to the Events Explorer
to the Events Explorer and fetch events from the Events Explorer. See the [Event
Management page](https://docs.datadoghq.com/service_management/events/) for more
information.

and fetch events from the Events Explorer. See the [Event Management page](https://docs.datadoghq.com/service_management/events/)
for more information.'

**Update to Datadog monitor events `aggregation_key` starting March 1, 2025:**
The Datadog monitor events `aggregation_key` is unique to each Monitor ID. Starting
March 1st, this key will also include Monitor Group, making it unique per *Monitor
ID and Monitor Group*. If you''re using monitor events `aggregation_key` in dashboard
queries or the Event API, you must migrate to use `@monitor.id`. Reach out to
[support](https://www.datadoghq.com/support/) if you have any question.'
name: Events
- description: 'Configure your Datadog-Google Cloud Platform (GCP) integration directly

Expand Down
13 changes: 10 additions & 3 deletions .generator/schemas/v2/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48310,10 +48310,17 @@ tags:
end times, prevent all alerting related to specified Datadog tags.'
name: Downtimes
- description: 'The Event Management API allows you to programmatically post events
to the Events Explorer
to the Events Explorer and fetch events from the Events Explorer. See the [Event
Management page](https://docs.datadoghq.com/service_management/events/) for more
information.

and fetch events from the Events Explorer. See the [Event Management page](https://docs.datadoghq.com/service_management/events/)
for more information.'

**Update to Datadog monitor events `aggregation_key` starting March 1, 2025:**
The Datadog monitor events `aggregation_key` is unique to each Monitor ID. Starting
March 1st, this key will also include Monitor Group, making it unique per *Monitor
ID and Monitor Group*. If you''re using monitor events `aggregation_key` in dashboard
queries or the Event API, you must migrate to use `@monitor.id`. Reach out to
[support](https://www.datadoghq.com/support/) if you have any question.'
name: Events
- description: Manage your Datadog Fastly integration accounts and services directly
through the Datadog API. See the [Fastly integration page](https://docs.datadoghq.com/integrations/fastly/)
Expand Down
4 changes: 2 additions & 2 deletions api/datadogV1/api_monitors.go
Original file line number Diff line number Diff line change
Expand Up @@ -635,8 +635,8 @@ func (r *ListMonitorsOptionalParameters) WithPageSize(pageSize int32) *ListMonit
return r
}

// ListMonitors Get all monitor details.
// Get details about the specified monitor from your organization.
// ListMonitors Get all monitors.
// Get all monitors from your organization.
func (a *MonitorsApi) ListMonitors(ctx _context.Context, o ...ListMonitorsOptionalParameters) ([]Monitor, *_nethttp.Response, error) {
var (
localVarHTTPMethod = _nethttp.MethodGet
Expand Down
2 changes: 1 addition & 1 deletion examples/v1/monitors/ListMonitors.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Get all monitor details returns "OK" response
// Get all monitors returns "OK" response

package main

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Get all monitor details with tags
// Get all monitors with tags

package main

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Get all monitor details returns "OK" response with pagination
// Get all monitors returns "OK" response with pagination

package main

Expand Down
9 changes: 8 additions & 1 deletion tests/scenarios/features/v1/events.feature
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,14 @@ Feature: Events
The Event Management API allows you to programmatically post events to the
Events Explorer and fetch events from the Events Explorer. See the [Event
Management page](https://docs.datadoghq.com/service_management/events/)
for more information.
for more information. **Update to Datadog monitor events
`aggregation_key` starting March 1, 2025:** The Datadog monitor events
`aggregation_key` is unique to each Monitor ID. Starting March 1st, this
key will also include Monitor Group, making it unique per *Monitor ID and
Monitor Group*. If you're using monitor events `aggregation_key` in
dashboard queries or the Event API, you must migrate to use `@monitor.id`.
Reach out to [support](https://www.datadoghq.com/support/) if you have any
question.

Background:
Given a valid "apiKeyAuth" key in the system
Expand Down
8 changes: 4 additions & 4 deletions tests/scenarios/features/v1/monitors.feature
Original file line number Diff line number Diff line change
Expand Up @@ -227,28 +227,28 @@ Feature: Monitors
And the response "options.synthetics_check_id" has the same value as "synthetics_api_test.public_id"

@team:DataDog/monitor-app
Scenario: Get all monitor details returns "Bad Request" response
Scenario: Get all monitors returns "Bad Request" response
Given new "ListMonitors" request
And request contains "group_states" parameter with value "notagroupstate"
When the request is sent
Then the response status is 400 Bad Request

@integration-only @team:DataDog/monitor-app
Scenario: Get all monitor details returns "OK" response
Scenario: Get all monitors returns "OK" response
Given new "ListMonitors" request
When the request is sent
Then the response status is 200 OK

@replay-only @skip-validation @team:DataDog/monitor-app @with-pagination
Scenario: Get all monitor details returns "OK" response with pagination
Scenario: Get all monitors returns "OK" response with pagination
Given new "ListMonitors" request
And request contains "page_size" parameter with value 2
When the request with pagination is sent
Then the response status is 200 OK
And the response has 3 items

@skip @team:DataDog/monitor-app
Scenario: Get all monitor details with tags
Scenario: Get all monitors with tags
Given there is a valid "monitor" in the system
And new "ListMonitors" request
And request contains "tags" parameter with value "test:{{ unique_lower_alnum }}"
Expand Down
9 changes: 8 additions & 1 deletion tests/scenarios/features/v2/events.feature
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,14 @@ Feature: Events
The Event Management API allows you to programmatically post events to the
Events Explorer and fetch events from the Events Explorer. See the [Event
Management page](https://docs.datadoghq.com/service_management/events/)
for more information.
for more information. **Update to Datadog monitor events
`aggregation_key` starting March 1, 2025:** The Datadog monitor events
`aggregation_key` is unique to each Monitor ID. Starting March 1st, this
key will also include Monitor Group, making it unique per *Monitor ID and
Monitor Group*. If you're using monitor events `aggregation_key` in
dashboard queries or the Event API, you must migrate to use `@monitor.id`.
Reach out to [support](https://www.datadoghq.com/support/) if you have any
question.

Background:
Given a valid "apiKeyAuth" key in the system
Expand Down

0 comments on commit 53808ac

Please sign in to comment.