Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTAGENT-293] upgrade modules used by otel to Go 1.23 #33993

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Feb 12, 2025

What does this PR do?

upgrade modules used by otel to Go 1.23

Motivation

OTel collector has dropped support for Go 1.22 and migrated to Go 1.23 open-telemetry/opentelemetry-collector-contrib#37875 . Agent modules that OTel depends on are no longer blocked to use Go 1.23.

@songy23 songy23 added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/opentelemetry-agent labels Feb 12, 2025
@songy23 songy23 added this to the 7.64.0 milestone Feb 12, 2025
@songy23 songy23 requested a review from a team as a code owner February 12, 2025 19:07
@songy23 songy23 requested a review from pgimalac February 12, 2025 19:07
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Feb 12, 2025
@songy23 songy23 requested review from a team as code owners February 12, 2025 19:34
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 12, 2025

Uncompressed package size comparison

Comparison with ancestor 4e0e6851ff20a44e11c73425a4e94f4c50755ebb

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 865.67MB 865.67MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 875.43MB 875.43MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 875.43MB 875.43MB 0.50MB
datadog-agent-arm64-deb 0.00MB 854.18MB 854.18MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 863.93MB 863.93MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 41.57MB 41.57MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 41.64MB 41.64MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 41.64MB 41.64MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 39.83MB 39.83MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 441.05MB 441.05MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 61.75MB 61.75MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 61.82MB 61.82MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 61.82MB 61.82MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.08MB 59.08MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 837.32MiB 847.49MiB 202.77MiB 212.83MiB
static_quality_gate_docker_agent_amd64 921.72MiB 931.7MiB 308.65MiB 318.67MiB
static_quality_gate_docker_agent_arm64 934.1MiB 944.08MiB 292.65MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.11GiB 383.79MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.09GiB 1.11GiB 363.73MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 47.86MiB 57.88MiB 18.29MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.26MiB 56.27MiB 17.05MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 267.75MiB 277.7MiB 107.3MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 283.79MiB 293.73MiB 102.15MiB 112.12MiB

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8f9fd112-9281-461a-bbac-aafbd177fecf

Baseline: 4e0e685
Comparison: 1f1b664
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +3.43 [+0.29, +6.57] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +1.72 [+0.82, +2.62] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.56 [+0.10, +1.02] 1 Logs
quality_gate_idle memory utilization +0.28 [+0.22, +0.33] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.26 [-0.52, +1.04] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.17 [-0.60, +0.94] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.82, +0.86] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.84, +0.87] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.65] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.03] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.74, +0.73] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.29, +0.27] 1 Logs
file_tree memory utilization -0.05 [-0.11, +0.00] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.06 [-0.89, +0.78] 1 Logs
quality_gate_idle_all_features memory utilization -0.15 [-0.20, -0.10] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -1.59 [-1.66, -1.51] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@songy23
Copy link
Member Author

songy23 commented Feb 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2025

View all feedbacks in Devflow UI.
2025-02-13 14:02:55 UTC ℹ️ Start processing command /merge


2025-02-13 14:02:59 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 33m.


2025-02-13 14:51:28 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit dee20b3 into main Feb 13, 2025
247 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yang.song/OTAGENT-293 branch February 13, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/opentelemetry-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants