Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network Path] Add test go build tag #33805

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ken-schneider
Copy link
Contributor

@ken-schneider ken-schneider commented Feb 6, 2025

What does this PR do?

Adds the go:build test tag to a unit test file which was missing before

Motivation

Noticed the missing tag, the test should not be included in the binary.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@ken-schneider ken-schneider requested review from a team as code owners February 6, 2025 21:07
@ken-schneider ken-schneider added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Feb 6, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 6, 2025
@ken-schneider
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 6, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-06 21:09:59 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!


⏳ Processing ...

@ken-schneider ken-schneider added the backport/7.63.x Automatically create a backport PR to 7.63.x label Feb 6, 2025
@ken-schneider ken-schneider changed the title add test go build tag [Network Path] Add test go build tag Feb 6, 2025
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 845.13MiB 858.45MiB 203.58MiB 214.3MiB
static_quality_gate_docker_agent_amd64 929.34MiB 942.69MiB 310.72MiB 321.56MiB

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55184084 --os-family=ubuntu

Note: This applies to commit 5a11f99

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 76c1c8552c36f43af539044fa3d6808fc71dc617

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 873.68MB 873.68MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 883.42MB 883.42MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 883.42MB 883.42MB 0.50MB
datadog-agent-arm64-deb 0.00MB 861.56MB 861.56MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 871.28MB 871.28MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.10MB 59.10MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.18MB 59.18MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.18MB 59.18MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.57MB 56.57MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 446.07MB 446.07MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.49MB 86.49MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.56MB 86.56MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.55MB 86.55MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.76MB 82.76MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.83MB 82.83MB 0.50MB

Decision

✅ Passed

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a38ade7f-5ef4-479f-98a3-217d11981575

Baseline: 76c1c85
Comparison: 5a11f99
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +0.65 [+0.61, +0.70] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.28 [+0.21, +0.34] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.03 [-0.85, +0.91] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.03 [-0.74, +0.80] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.77, +0.81] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.67, +0.68] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.27, +0.27] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.87, +0.86] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.65, +0.62] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.95, +0.90] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.06 [-0.95, +0.84] 1 Logs
quality_gate_idle_all_features memory utilization -0.06 [-0.13, +0.01] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.06 [-0.53, +0.41] 1 Logs
file_tree memory utilization -0.11 [-0.18, -0.04] 1 Logs
quality_gate_logs % cpu utilization -1.45 [-4.48, +1.57] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.63.x Automatically create a backport PR to 7.63.x changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant