Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCII-2748] Stop excluding checks from checks.execution_time telemetry #33795

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

pgimalac
Copy link
Member

@pgimalac pgimalac commented Feb 6, 2025

What does this PR do?

Remove the exclusions from the instrumentation telemetry config of checks.execution_time.

Motivation

We want to know whether the default checks are run and if so if it's a Python or Go implementation.

Describe how you validated your changes

CI and manual checking that the checks appear in instrumentation telemetry.

Possible Drawbacks / Trade-offs

Additional Notes

@pgimalac pgimalac added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-runtimes labels Feb 6, 2025
@pgimalac pgimalac requested review from iglendd and a team as code owners February 6, 2025 17:44
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 6, 2025
@pgimalac pgimalac added the need-change/agenttelemetry-governance Add this label if your change requires also a change in agent telemetry governance (internal) label Feb 6, 2025
@pgimalac pgimalac changed the title Stop excluding checks from checks.execution_time telemetry [ASCII-2748] Stop excluding checks from checks.execution_time telemetry Feb 6, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 6, 2025

Uncompressed package size comparison

Comparison with ancestor 9751798d893e2bae7129447e1c9a82962dcad898

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 873.68MB 873.68MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 883.42MB 883.42MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 883.42MB 883.42MB 0.50MB
datadog-agent-arm64-deb 0.00MB 861.56MB 861.56MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 871.28MB 871.28MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.10MB 59.10MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.18MB 59.18MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.18MB 59.18MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.57MB 56.57MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 446.07MB 446.07MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.49MB 86.49MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.56MB 86.56MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.55MB 86.55MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.76MB 82.76MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.83MB 82.83MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 6, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55159864 --os-family=ubuntu

Note: This applies to commit 1ec26e6

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 6, 2025

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 845.04MiB 858.45MiB 203.58MiB 214.3MiB
static_quality_gate_docker_agent_amd64 929.34MiB 942.69MiB 310.73MiB 321.56MiB

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b058ae65-4039-4b7e-9d09-1d99c7435227

Baseline: 9751798
Comparison: 1ec26e6
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.93 [+0.05, +1.81] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.85 [+0.78, +0.93] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.10 [-0.76, +0.97] 1 Logs
quality_gate_idle memory utilization +0.03 [-0.01, +0.07] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.87, +0.91] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.77, +0.81] 1 Logs
quality_gate_idle_all_features memory utilization +0.01 [-0.05, +0.08] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api ingress throughput +0.01 [-0.27, +0.29] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.83, +0.84] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.64, +0.63] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.04 [-0.79, +0.70] 1 Logs
file_tree memory utilization -0.12 [-0.19, -0.05] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.38 [-0.85, +0.09] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.93 [-1.71, -0.16] 1 Logs
quality_gate_logs % cpu utilization -1.60 [-4.63, +1.44] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@pgimalac
Copy link
Member Author

pgimalac commented Feb 7, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 7, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-07 10:09:05 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.


2025-02-07 10:36:14 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit bdcde74 into main Feb 7, 2025
225 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pgimalac/stop-exclude-checks-exec-time branch February 7, 2025 10:36
@github-actions github-actions bot added this to the 7.64.0 milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog need-change/agenttelemetry-governance Add this label if your change requires also a change in agent telemetry governance (internal) qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-runtimes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants