[FA][HA Agent] Add config_id only to agent running metrics

[AlexandreYang]

What does this PR do?

[HA Agent] Add config_id only to agent running metrics

Motivation

config_id is only needed on datadog.agent.running and datadog.agent.ha_agent.running metrics.
Hence, we are making sure in this PR that config_id tag is not added elsewhere.

More concretely, it will avoid datadog.agent.started metric to be tagged with config_id (not needed).

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 9bca79acdf864311357661fc906f3007f2c18db3

Diff per package

package	diff	status	size	ancestor	threshold
datadog-iot-agent-aarch64-rpm	0.01MB	⚠️	89.96MB	89.96MB	0.50MB
datadog-iot-agent-arm64-deb	0.01MB	⚠️	89.89MB	89.89MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	886.93MB	886.92MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	886.93MB	886.92MB	0.50MB
datadog-agent-amd64-deb	0.00MB	✅	877.19MB	877.18MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	456.45MB	456.45MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	93.91MB	93.91MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	93.91MB	93.91MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	59.10MB	59.10MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	59.10MB	59.10MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	864.97MB	864.97MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	59.02MB	59.02MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.51MB	56.51MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	93.84MB	93.84MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	874.69MB	874.69MB	0.50MB

Decision

⚠️ Warning

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 84cfea39-62ae-4581-b26e-632472a310aa

Baseline: 9bca79a
Comparison: bc8b1af
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.47	[-0.33, +1.26]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.38	[-0.50, +1.26]	1	Logs
➖	quality_gate_idle	memory utilization	+0.36	[+0.32, +0.40]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.25	[-0.22, +0.73]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.09	[+0.03, +0.16]	1	Logs bounds checks dashboard
➖	file_to_blackhole_500ms_latency	egress throughput	+0.09	[-0.70, +0.89]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.05	[-0.83, +0.93]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.64, +0.71]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.25, +0.30]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.02	[-0.88, +0.92]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.00	[-0.93, +0.93]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.02	[-0.65, +0.61]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.09	[-0.17, -0.01]	1	Logs
➖	file_tree	memory utilization	-0.57	[-0.64, -0.51]	1	Logs
➖	quality_gate_logs	% cpu utilization	-2.64	[-5.68, +0.40]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54712041 --os-family=ubuntu

Note: This applies to commit bc8b1af

[coignetp]

❓ question: ‏Do we prefer a new method or keep it consistent with withVersion parameter in tags method, and add a new parameter withConfigID?

[AlexandreYang]

@coignetp I think passing withVersion boolean param is an anti-pattern, it means that the function/method is doing two things, which is usually a bad pattern: https://softwareengineering.stackexchange.com/questions/147977/is-it-wrong-to-use-a-boolean-parameter-to-determine-behavior

This should be probably replace with two methods:

• agg.tags()
• agg.tagsWithVersion()

for example.

Suggestion for @DataDog/agent-metrics , maybe someone to improve :D

[remeh]

Is there any reason to have it on datadog.agent.running if you have it on datadog.agent.ha_agent.running?

[AlexandreYang]

@remeh thanks for the review, I added this comment here: bc8b1af

The metric datadog.agent.running is the one used by Fleet and HA to know if the agent is running.

datadog.agent.ha_agent.running is currently only meant to be used in dashboard to monitor HA Agent state (active/standby) over time. I had to use a different metric since ha_agent_state tag is dynamic, and not suitable to be added to datadog.agent.running.

[AlexandreYang]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2025-02-03 16:12:55 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 27m.

---

2025-02-03 16:39:50 UTC ❌ MergeQueue: This merge request is not mergeable, blocked by github

PR can't be merged according to github policy

[remeh]

LGTM

[AlexandreYang]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2025-02-04 08:45:58 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 27m.

---

2025-02-04 09:26:16 UTC ℹ️ MergeQueue: This merge request was merged