Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACIX-499] Replaced developer experience channel by id #32759

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

CelianR
Copy link
Contributor

@CelianR CelianR commented Jan 8, 2025

What does this PR do?

Now the channel is the proper one 😁

Example:

Screenshot 2025-01-08 at 10 57 02

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@CelianR CelianR added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra labels Jan 8, 2025
@CelianR CelianR self-assigned this Jan 8, 2025
@CelianR CelianR marked this pull request as ready for review January 8, 2025 09:58
@CelianR CelianR requested review from a team as code owners January 8, 2025 09:58
@CelianR CelianR added ask-review Ask required teams to review this PR and removed ask-review Ask required teams to review this PR labels Jan 8, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 8, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=52535599 --os-family=ubuntu

@CelianR
Copy link
Contributor Author

CelianR commented Jan 9, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 9, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-09 08:31:41 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-09 10:31:47 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@CelianR
Copy link
Contributor Author

CelianR commented Jan 9, 2025

/remove

@dd-devflow
Copy link

dd-devflow bot commented Jan 9, 2025

Devflow running: /remove

View all feedbacks in Devflow UI.


2025-01-09 10:31:46 UTC ℹ️ Devflow: /remove

@CelianR
Copy link
Contributor Author

CelianR commented Jan 9, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 9, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-09 10:32:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-09 12:31:44 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request: It did not become mergeable within the expected time

@CelianR
Copy link
Contributor Author

CelianR commented Jan 9, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 9, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-09 12:41:00 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-09 15:35:55 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@chouetz chouetz merged commit 354ad11 into 6.53.x Jan 9, 2025
115 checks passed
@chouetz chouetz deleted the celian/notif-acix-499 branch January 9, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants