Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-git to latest version #32719

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Bump go-git to latest version #32719

merged 1 commit into from
Jan 7, 2025

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Jan 7, 2025

What does this PR do?

Bump go-git to latest version

Motivation

#incident-33737

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 7, 2025
@chouetz chouetz added backport/6.53.x automatically create a backport PR to 6.53.x backport/7.61.x Automatically create a backport PR to 7.61.x backport/7.62.x Automatically create a backport PR to 7.62.x labels Jan 7, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 7, 2025

Uncompressed package size comparison

Comparison with ancestor 5001b1918581599fd499ee15c64d7738f2580fa2

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.02MB ⚠️ 949.99MB 949.97MB 140.00MB
datadog-agent-arm64-deb 0.02MB ⚠️ 940.69MB 940.67MB 140.00MB
datadog-agent-amd64-deb 0.00MB 1011.32MB 1011.32MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1020.64MB 1020.63MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1020.64MB 1020.63MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 58.61MB 58.61MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.69MB 58.69MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.69MB 58.69MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 56.13MB 56.13MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 506.13MB 506.13MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.80MB 113.80MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.87MB 113.87MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.87MB 113.87MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 109.24MB 109.24MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 109.31MB 109.31MB 10.00MB

Decision

⚠️ Warning

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3b6d96e1-b3a2-41e5-a4e5-af56e9a445a3

Baseline: 5001b19
Comparison: c043dc9
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +0.94 [+0.89, +0.98] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.17 [-0.29, +0.64] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.15 [-0.54, +0.84] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.06 [-0.84, +0.95] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.05 [-0.82, +0.93] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.05 [-0.74, +0.83] 1 Logs
quality_gate_idle_all_features memory utilization +0.02 [-0.06, +0.10] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.61, +0.65] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.10, +0.11] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.92, +0.93] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.64, +0.63] 1 Logs
file_tree memory utilization -0.05 [-0.18, +0.09] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.56 [-0.63, -0.50] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.61 [-1.42, +0.19] 1 Logs
quality_gate_logs % cpu utilization -1.16 [-4.32, +2.01] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jan 7, 2025
@chouetz
Copy link
Member Author

chouetz commented Jan 7, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 7, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-07 12:32:47 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-07 12:33:50 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 35m.


2025-01-07 13:07:30 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2d2dde6 into main Jan 7, 2025
264 of 276 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nschweitzer/go-git branch January 7, 2025 13:07
@github-actions github-actions bot added this to the 7.63.0 milestone Jan 7, 2025
@agent-platform-auto-pr
Copy link
Contributor

The backport to 6.53.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-6.53.x 6.53.x
# Navigate to the new working tree
cd .worktrees/backport-6.53.x
# Create a new branch
git switch --create backport-32719-to-6.53.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2d2dde61c7c07aca7e69d0a0ba20fbd42a74e483
# Push it to GitHub
git push --set-upstream origin backport-32719-to-6.53.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-6.53.x

Then, create a pull request where the base branch is 6.53.x and the compare/head branch is backport-32719-to-6.53.x.

@agent-platform-auto-pr
Copy link
Contributor

The backport to 7.61.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.61.x 7.61.x
# Navigate to the new working tree
cd .worktrees/backport-7.61.x
# Create a new branch
git switch --create backport-32719-to-7.61.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2d2dde61c7c07aca7e69d0a0ba20fbd42a74e483
# Push it to GitHub
git push --set-upstream origin backport-32719-to-7.61.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.61.x

Then, create a pull request where the base branch is 7.61.x and the compare/head branch is backport-32719-to-7.61.x.

@agent-platform-auto-pr
Copy link
Contributor

The backport to 7.62.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.62.x 7.62.x
# Navigate to the new working tree
cd .worktrees/backport-7.62.x
# Create a new branch
git switch --create backport-32719-to-7.62.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2d2dde61c7c07aca7e69d0a0ba20fbd42a74e483
# Push it to GitHub
git push --set-upstream origin backport-32719-to-7.62.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.62.x

Then, create a pull request where the base branch is 7.62.x and the compare/head branch is backport-32719-to-7.62.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/6.53.x automatically create a backport PR to 6.53.x backport/7.61.x Automatically create a backport PR to 7.61.x backport/7.62.x Automatically create a backport PR to 7.62.x changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants