[ADXT-816] Dump e2e logs with failing / flaky categories #32653

CelianR · 2025-01-03T16:34:50Z

What does this PR do?

Splits e2e logs into four categories with the following priority (the higher the more priority it has):

Failing / non flaky
Failing / flaky
Successful / non flaky
Successful / flaky

If there is no more room to print a category, logs won't be printed so the more priority a category has, the more it has chance to appear on the logs.

In addition, a unit test is added to verify that tests are categorized.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Example within a job log

Example with 2 non flaky tests and 1 flaky test.

Max size = 20:

WARNING: Too many logs to print, skipping logs printing to avoid Gitlab collapse. You can find your logs properly organized in the job artifacts: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/None/artifacts/browse/e2e-output/logs/

Max size = 200:

Max size = 2000:

agent-platform-auto-pr · 2025-01-03T16:57:27Z

[Fast Unit Tests Report]

On pipeline 52637258 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

agent-platform-auto-pr · 2025-01-03T17:00:32Z

Uncompressed package size comparison

Comparison with ancestor 20eef2836c876c9e9b24f0d185fcbc649ab8a86b

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	1012.77MB	1012.77MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	1022.09MB	1022.09MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	1022.09MB	1022.09MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	941.95MB	941.95MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	951.24MB	951.24MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	58.83MB	58.83MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	58.90MB	58.90MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	58.90MB	58.90MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.33MB	56.33MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	506.57MB	506.57MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	114.00MB	114.00MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	114.07MB	114.07MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	114.07MB	114.07MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	109.44MB	109.44MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	109.51MB	109.51MB	0.50MB

Decision

✅ Passed

cit-pr-commenter · 2025-01-03T17:28:19Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 40e8eba6-71f9-4e2e-a694-ccf427fb9238

Baseline: 20eef28
Comparison: 2dbebfb
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+3.39	[+0.09, +6.69]	1	Logs
➖	quality_gate_idle	memory utilization	+0.51	[+0.46, +0.55]	1	Logs bounds checks dashboard
➖	file_to_blackhole_100ms_latency	egress throughput	+0.07	[-0.61, +0.76]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.04	[-0.78, +0.86]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.04	[-0.85, +0.93]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.02	[-0.76, +0.81]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.02	[-0.61, +0.65]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.12, +0.12]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_tree	memory utilization	-0.00	[-0.14, +0.13]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.04	[-0.96, +0.88]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.05	[-0.72, +0.62]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.23	[-0.30, -0.16]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.28	[-0.75, +0.19]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.48	[-0.57, -0.39]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.64	[-1.43, +0.15]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

pducolin

Very nice! Kudos for the PR description, screenshots help seeing what this results on

chouetz

Cosmetic comments

tasks/new_e2e_tests.py

CelianR · 2025-01-09T12:38:08Z

/merge

dd-devflow · 2025-01-09T12:38:20Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2025-01-09 12:38:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-01-09 16:38:37 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request: It did not become mergeable within the expected time

CelianR · 2025-01-10T08:35:28Z

/merge

dd-devflow · 2025-01-10T08:35:39Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2025-01-10 08:35:39 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-01-10 09:32:41 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 35m.

2025-01-10 10:07:49 UTC ℹ️ MergeQueue: This merge request was merged

[dump-logs-adxt-816] Print file

dad14c9

CelianR added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra labels Jan 3, 2025

CelianR self-assigned this Jan 3, 2025

github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 3, 2025

CelianR added 5 commits January 6, 2025 13:09

[dump-logs-adxt-816] Added log dump split

e20843d

[dump-logs-adxt-816] Fixed wrong path

a44412e

[dump-logs-adxt-816] Implem

6c782b1

[dump-logs-adxt-816] Fixed pretty print

2b51b95

[dump-logs-adxt-816] Added unit tests

dfd8457

CelianR marked this pull request as ready for review January 7, 2025 09:19

CelianR requested review from a team as code owners January 7, 2025 09:19

CelianR changed the title ~~[ADXT-816] Dump e2e logs~~ [ADXT-816] Dump e2e logs with failing / flaky categories Jan 7, 2025

CelianR added the ask-review Ask required teams to review this PR label Jan 7, 2025

pducolin approved these changes Jan 7, 2025

View reviewed changes

[dump-logs-adxt-816] Fixed typo

c7182ab

chouetz approved these changes Jan 8, 2025

View reviewed changes

tasks/new_e2e_tests.py Outdated Show resolved Hide resolved

tasks/new_e2e_tests.py Outdated Show resolved Hide resolved

tasks/new_e2e_tests.py Outdated Show resolved Hide resolved

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 8, 2025

CelianR added 2 commits January 8, 2025 16:32

[dump-logs-adxt-816] Applied suggestions

46eda5f

[dump-logs-adxt-816] Applied suggestions v2

3b63285

chouetz approved these changes Jan 8, 2025

View reviewed changes

Merge branch 'main' into celian/dump-logs-adxt-816

2dbebfb

dd-mergequeue bot merged commit bdc78a5 into main Jan 10, 2025
212 checks passed

dd-mergequeue bot deleted the celian/dump-logs-adxt-816 branch January 10, 2025 10:07

github-actions bot added this to the 7.63.0 milestone Jan 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADXT-816] Dump e2e logs with failing / flaky categories #32653

[ADXT-816] Dump e2e logs with failing / flaky categories #32653

CelianR commented Jan 3, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 3, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 3, 2025 •

edited

Loading

cit-pr-commenter bot commented Jan 3, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

pducolin left a comment

chouetz left a comment

CelianR commented Jan 9, 2025

dd-devflow bot commented Jan 9, 2025 •

edited

Loading

CelianR commented Jan 10, 2025

dd-devflow bot commented Jan 10, 2025 •

edited

Loading

[ADXT-816] Dump e2e logs with failing / flaky categories #32653

[ADXT-816] Dump e2e logs with failing / flaky categories #32653

Conversation

CelianR commented Jan 3, 2025 • edited Loading

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Jan 3, 2025 • edited Loading

agent-platform-auto-pr bot commented Jan 3, 2025 • edited Loading

Uncompressed package size comparison

Decision

cit-pr-commenter bot commented Jan 3, 2025 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

pducolin left a comment

Choose a reason for hiding this comment

chouetz left a comment

Choose a reason for hiding this comment

CelianR commented Jan 9, 2025

dd-devflow bot commented Jan 9, 2025 • edited Loading

Devflow running: /merge

CelianR commented Jan 10, 2025

dd-devflow bot commented Jan 10, 2025 • edited Loading

Devflow running: /merge

CelianR commented Jan 3, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 3, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 3, 2025 •

edited

Loading

cit-pr-commenter bot commented Jan 3, 2025 •

edited

Loading

dd-devflow bot commented Jan 9, 2025 •

edited

Loading

Devflow running: `/merge`

dd-devflow bot commented Jan 10, 2025 •

edited

Loading

Devflow running: `/merge`