[RUMF-886] don't start recording when 'postpone_start_recording' is enabled #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nabled Don't automatically start recording when an outdated snippet is used. Outdated snippets, that are still using `postpone_start_recording` and aren't using `manualSessionReplayRecordingStart`, are problematic because the recording starts when using DD_RUM.init even if it should be postponed.
webNeat
approved these changes
Apr 13, 2021
bcaudan
approved these changes
Apr 13, 2021
BenoitZugmeyer
deleted the
benoit/restore-postpone-start-recording-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Snippets, that are still using
postpone_start_recordingand aren't usingmanualSessionReplayRecordingStart: false, are problematic because the recording starts when using DD_RUM.init even if it should be postponed.Changes
Don't automatically start recording when
postpone_start_recordingexperimental feature is enabled.Testing
CI, manual
I have gone over the contributing documentation.