🐛 [RUMF-834] fix loop direction #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing rrweb code, I made a typo and `index--` became `index += 1`. ecc09e7#diff-7e32def6242fea74b49dc8381d38f18941e632957f7cea33951a0ecb07597705L280-R281
bcaudan
reviewed
Feb 3, 2021
| @@ -281,7 +281,7 @@ export class MutationBuffer { | |||
| } | |||
| } | |||
| if (!node) { | |||
| for (let index = addList.length - 1; index >= 0; index += 1) { | |||
| for (let index = addList.length - 1; index >= 0; index -= 1) { | |||
There was a problem hiding this comment.
could it be a good opportunity to add a test?
There was a problem hiding this comment.
I'll see what I can do
vlad-mh
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When importing rrweb code, I made a typo and
index--becameindex += 1.ecc09e7#diff-7e32def6242fea74b49dc8381d38f18941e632957f7cea33951a0ecb07597705L280-R281
It should fix the "Cannot read property 'value' of null" and "Position outside of list" errors
Changes
Restore loop direction!
Testing
I have gone over the contributing documentation.