Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a rum-core package #673

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jan 5, 2021

Motivation

The rum-core package will be used by both rum and rum-recorder packages. It will mutualize RUM internals.

Changes

  • Create a rum-core package
  • Rename some 'global' to 'publicApi' to make things clearer

Testing


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested review from a team as code owners January 5, 2021 17:36
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/create-rum-core-package branch 3 times, most recently from 6db1bca to 22ddbf4 Compare January 6, 2021 09:30
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/create-rum-core-package branch from 22ddbf4 to fe3907f Compare January 6, 2021 09:31
@codecov-io
Copy link

Codecov Report

Merging #673 (fe3907f) into master (eb89c9b) will increase coverage by 0.13%.
The diff coverage is 94.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
+ Coverage   77.72%   77.86%   +0.13%     
==========================================
  Files          60       60              
  Lines        3268     3266       -2     
  Branches      710      710              
==========================================
+ Hits         2540     2543       +3     
+ Misses        728      723       -5     
Impacted Files Coverage Δ
packages/rum-core/src/boot/buildEnv.ts 100.00% <ø> (ø)
packages/rum-core/src/boot/rum.ts 50.00% <ø> (ø)
...ages/rum-core/src/browser/domMutationCollection.ts 89.47% <ø> (ø)
...ages/rum-core/src/browser/performanceCollection.ts 17.24% <ø> (ø)
packages/rum-core/src/domain/assembly.ts 100.00% <ø> (ø)
packages/rum-core/src/domain/internalContext.ts 100.00% <ø> (ø)
packages/rum-core/src/domain/lifeCycle.ts 100.00% <ø> (ø)
packages/rum-core/src/domain/parentContexts.ts 98.24% <ø> (ø)
packages/rum-core/src/domain/requestCollection.ts 87.87% <ø> (ø)
...ain/rumEventsCollection/action/actionCollection.ts 94.11% <ø> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb89c9b...fe3907f. Read the comment docs.

Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenoitZugmeyer BenoitZugmeyer merged commit e35ef9f into master Jan 6, 2021
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/create-rum-core-package branch January 6, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants