✨ [RUMF-385] improve click action naming #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the algorithm in various ways:
* Re-prioritize the name strategy:
* use textual content in very precise cases in priority (ex: BUTTON
element), together with other techniques (attributes, label, ...)
* then fallback on the textual content of any element
* Use a related LABEL element
* Use a child OPTION to name a SELECT element
* Support more attributes: name, aria-labelledby, role=button
* Implement a parent recursion with a hard limit to 10 and up to a FORM element
* Ignore inline SCRIPT content and other hidden elements when computing textual content
* Ignore textual data when using content-editable elements and children
* Normalize the whitespaces
* Ignore BODY, HTML and HEAD elements
* getElementContent -> getActionNameFromElement * element content -> element textual content * other 'content' uses -> name
BenoitZugmeyer
changed the title
BenoitZugmeyer
changed the title
bcaudan
reviewed
May 28, 2020
Comment on lines
131
to
132
| // tslint:disable-next-line: prefer-for-of | ||
| for (let i = 0; i < elementsToRemove.length; i += 1) { |
There was a problem hiding this comment.
according to MDN for-of should work correctly on node list, typing does not seem to allow that though.
it could worth to check if it is supported by newer ts version but not important now
There was a problem hiding this comment.
It appears to be working on two conditions:
- use the DOM.Iterable
lib - and use ES6+ as a
targetor thedownlevelIterationoption
I'll keep the traditional for loop here for now.
* add some comments * remove some comments * rename some variables * add an explicit constant for the recursion limit
bcaudan
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve the name of click actions.
Changes
Testing
This should be left on staging for a little while to verify that it does not break thing, and indeed improve the action names.
I have gone over the contributing documentation.