-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ mitigate e2e protocol latency #3295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3295 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 288 288
Lines 7617 7617
Branches 1739 1739
=======================================
Hits 7136 7136
Misses 481 481 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
86db842
to
7415e47
Compare
7415e47
to
f74b4cf
Compare
BenoitZugmeyer
approved these changes
Jan 22, 2025
RomanGaignault
approved these changes
Jan 22, 2025
@@ -683,7 +683,7 @@ describe('recorder', () => { | |||
}) | |||
|
|||
createTest('should detect a rage click and match it to mouse interaction records') | |||
.withRum({ trackUserInteractions: true }) | |||
.withRum({ trackUserInteractions: true, allowUntrustedEvents: true }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥜 nitpick:
allowUntrustedEvents: true, |
allowUntrustedEvents: true
should already be enabled by default
BenoitZugmeyer
approved these changes
Jan 22, 2025
RomanGaignault
pushed a commit
that referenced
this pull request
Jan 22, 2025
RomanGaignault
pushed a commit
that referenced
this pull request
Jan 22, 2025
RomanGaignault
pushed a commit
that referenced
this pull request
Jan 22, 2025
RomanGaignault
pushed a commit
that referenced
this pull request
Jan 22, 2025
RomanGaignault
pushed a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
two e2e test start failing quite consistently since around a week ago on Chrome android. The root cause is increased latency in the webdriver <> browserstack connection wich makes 3 consecutive clicks happens slower than a second, not triggering the expected
rage_click
frustration.Changes
The mitigation involve using synthetic events instead of webdriver's API to guaranty the clicks happens fast enough to be recognized as rage clicks.
This is not ideal and will be revisited in the future when we move away from webdriver protocol.
Testing
I have gone over the contributing documentation.