-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Collect long animation frames as long task events #3272
Conversation
acdc77d
to
c3dbf48
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3272 +/- ##
==========================================
+ Coverage 93.51% 93.53% +0.02%
==========================================
Files 288 288
Lines 7599 7598 -1
Branches 1730 1730
==========================================
+ Hits 7106 7107 +1
+ Misses 493 491 -2 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
test/e2e/lib/helpers/browser.ts
Outdated
const filterdLogs = logs.filter( | ||
// Ignore long-animation-frame warning (only happens on Edge) | ||
(log) => !log.message.includes("The entry type 'long-animation-frame' does not exist or isn't supported") | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of e2e are verifying the number browser logs (example)
Another solution would be to makes these test for the console log they are actually expecting. But at the same time it is nice to ensure there is no unexpected console logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion:
We should probably adjust performanceObservable.ts
to skip observing unsupported entries to avoid spamming the console on customer websites. Something like:
if (!supportPerformanceTimingEvent(options.type)) {
return
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performance.supportedEntryTypes
is not supported everywhere. For example,
Long Task are supported since chrome 58, but Performance.supportedEntryTypes
only since Chrome 73, while we supposedly support chrome 63+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well still, I think we should find a way to avoid displaying the warning in browsers without loaf support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, as finally we're falling back to Long tasks when LoAF is not supported, I'm starting either Loaf collection or Long task collection in startRum
depending on Performance.supportedEntryTypes
.
It should work to get rid of the warning because everywhere LoAF are supported Performance.supportedEntryTypes
is also supported.
b7171fe
to
923877d
Compare
Motivation
GA Collecting long animation frames
Changes
Testing
I have gone over the contributing documentation.