-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUM-6565] Capture previous and current rects in CLS attribution data #3269
Conversation
@@ -433,6 +433,7 @@ export type TelemetryCommonFeaturesUsage = | |||
| AddError | |||
| SetGlobalContext | |||
| SetUser | |||
| SetAccount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The account-related changes here got pulled in by yarn rum-events-format:sync
. They're unrelated to the PR, but unfortunately it's hard to avoid pulling them in because of the order in which things got merged into rum-events-format
. They'll disappear from the diff if Nicolas merges the PR that motivated them before this one lands, though, so the issue is temporary.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3269 +/- ##
==========================================
- Coverage 93.67% 93.66% -0.01%
==========================================
Files 288 288
Lines 7607 7613 +6
Branches 1735 1739 +4
==========================================
+ Hits 7126 7131 +5
- Misses 481 482 +1 ☔ View full report in Codecov by Sentry. |
packages/rum-core/src/domain/view/viewMetrics/trackCumulativeLayoutShift.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/view/viewMetrics/trackCumulativeLayoutShift.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/view/viewMetrics/trackCumulativeLayoutShift.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/view/viewMetrics/trackCumulativeLayoutShift.ts
Outdated
Show resolved
Hide resolved
9102f3f
to
6999e09
Compare
40366f4
to
b4ca6f8
Compare
b4ca6f8
to
6d9e2b1
Compare
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
6d9e2b1
to
91ea40a
Compare
Motivation
When trying to understand the causes and impact of a Cumulative Layout Shift score, it's often helpful to see how the affected element's position and size has changed.
Changes
This PR adds the capability to capture the previous and current rects associated with layout shifts on supported browsers. The changes build on the standard LayoutShiftAttribution API and the recent changes in rum-events-format which gave us a place to store this data.
Testing
I have gone over the contributing documentation.