Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ fix session store e2e to account for anonymous id #3265

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

thomas-lebeau
Copy link
Collaborator

Motivation

In v6 we now have both id and aid in the session cookie / local storage

Changes

fix e2e to match id but not aid

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@thomas-lebeau thomas-lebeau marked this pull request as ready for review January 8, 2025 13:03
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner January 8, 2025 13:03
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (27a0665) to head (a6884e4).

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #3265      +/-   ##
==========================================
- Coverage   93.64%   93.51%   -0.14%     
==========================================
  Files         288      288              
  Lines        7599     7599              
  Branches     1730     1730              
==========================================
- Hits         7116     7106      -10     
- Misses        483      493      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 144.54 KiB 144.54 KiB 0 B 0.00%
Logs 51.13 KiB 51.13 KiB 0 B 0.00%
Rum Slim 103.39 KiB 103.39 KiB 0 B 0.00%
Worker 24.50 KiB 24.50 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 0.000
addaction 0.052 0.070 0.019
addtiming 0.001 0.001 0.000
adderror 0.050 0.049 -0.002
startstopsessionreplayrecording 0.009 0.008 -0.001
startview 0.396 0.404 0.008
logmessage 0.027 0.020 -0.007
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 31.76 KiB 28.65 KiB -3183 B
addaction 56.89 KiB 52.76 KiB -4231 B
addtiming 27.74 KiB 26.02 KiB -1758 B
adderror 59.38 KiB 57.15 KiB -2288 B
startstopsessionreplayrecording 26.69 KiB 26.32 KiB -377 B
startview 414.42 KiB 412.51 KiB -1961 B
logmessage 60.26 KiB 58.61 KiB -1691 B

🔗 RealWorld

@thomas-lebeau thomas-lebeau merged commit 6d238d8 into v6 Jan 8, 2025
16 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/fix-session-storage-e2e branch January 8, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants