Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 fix CI PR comment #3250

Merged
merged 2 commits into from
Jan 6, 2025
Merged

💚 fix CI PR comment #3250

merged 2 commits into from
Jan 6, 2025

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jan 6, 2025

Motivation

The PR comments are broken since #3211 because LOCAL_BRANCH does not exist anymore (it has been replaced by a getLocalBranch function).

Changes

Restore LOCAL_BRANCH, remove getLocalBranch, as I don't see any reason why it should be a function (but maybe @amortemousque has more context)

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner January 6, 2025 13:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (6fb4e3c) to head (dab7b97).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3250      +/-   ##
==========================================
- Coverage   93.34%   93.33%   -0.02%     
==========================================
  Files         287      287              
  Lines        7786     7786              
  Branches     1759     1759              
==========================================
- Hits         7268     7267       -1     
- Misses        518      519       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.50 KiB 161.50 KiB 0 B 0.00%
Logs 55.95 KiB 55.95 KiB 0 B 0.00%
Rum Slim 111.55 KiB 111.55 KiB 0 B 0.00%
Worker 24.54 KiB 24.54 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 -0.000
addaction 0.039 0.039 0.001
addtiming 0.001 0.001 0.000
adderror 0.042 0.046 0.004
startstopsessionreplayrecording 1.131 1.053 -0.078
startview 0.395 0.490 0.095
logmessage 0.021 0.023 0.003
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 6.95 KiB 9.15 KiB 2.20 KiB
addaction 39.57 KiB 42.35 KiB 2.78 KiB
addtiming 6.31 KiB 6.80 KiB 498 B
adderror 44.03 KiB 45.31 KiB 1.28 KiB
startstopsessionreplayrecording 6.00 KiB 8.03 KiB 2.02 KiB
startview 419.17 KiB 427.90 KiB 8.73 KiB
logmessage 39.39 KiB 42.24 KiB 2.86 KiB

🔗 RealWorld

@BenoitZugmeyer BenoitZugmeyer merged commit 21975c7 into main Jan 6, 2025
19 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/fix-pr-comment branch January 6, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants