🐛 AddError should support all instances of type Error

[lightswitch05]

Motivation

Recently, all errors of type AxiosError stopped logging properly. Instead of the standard log with Error object, it was serializing the error object instead.

After some investigation I tracked down the regression to #3144 - which changes the object type check from param instanceof Error to Object.prototype.toString.call(error) === '[object Error]'. Unfortunately, the way AxiosError is created, that toString call just produces [object Object]. However, the instanceof check works just fine.

Changes

I've addressed the regression by using both the original instanceof Error check as well as the new toString check. Supporting both checks cover both the old and the new feature requirements.

Testing

I spent some time trying to get the tests running - but I was not successful. I don't doubt there might be some tweaks required in the PR, but I think the bulk of it is complete. Please feel free to modify the PR as needed. Hopefully this can get fixed quickly and we can all have AxiosError logging working again.

• Local
• Staging
• Unit
• End to end

---

I have gone over the contributing documentation.

[bits-bot]

All committers have signed the CLA.

[RomanGaignault]

/to-staging

[dd-devflow]

Devflow running: /to-staging

View all feedbacks in Devflow UI.

---

2024-12-18 15:23:41 UTC ℹ️ Branch Integration: starting soon, median merge time is 0s

Commit 26edcbf7d0 will soon be integrated into staging-51.

---

2024-12-18 15:27:46 UTC 🚨 Branch Integration: The build pipeline contains failing jobs for this merge request

We couldn't automatically merge the commit 26edcbf7d0 into staging-51.
Build pipeline has failing jobs for bb4ac3b:

• build-and-lint

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

• Investigate the failures and when ready, re-add your pull request to the queue!
• Any question, go check the FAQ.

If you think the errors come from a logical conflict with the target branch, you can create a fix by commenting this pull request with /create-fix-branch -b staging-51

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

[RomanGaignault]

@lightswitch05 the pr is merged, we will do a release soon 😃

[lightswitch05]

Just looping back to confirm AxiosError logging is back! Thank you for the quick response! 💪 🥳