Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 [RUM-7676] default traceContextInjection to sampled #3212

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Dec 12, 2024

Motivation

Improve Trace <> RUM correlation with RUM without limits

Changes

makes sampled the new default for traceContextInjection init option

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Copy link

cit-pr-commenter bot commented Dec 12, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 153.17 KiB 153.17 KiB 4 B 0.00%
Logs 50.97 KiB 50.97 KiB 0 B 0.00%
Rum Slim 103.14 KiB 103.14 KiB 4 B 0.00%
Worker 25.16 KiB 25.16 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 -0.000
addaction 0.127 0.065 -0.062
addtiming 0.001 0.001 -0.000
adderror 0.118 0.067 -0.051
startstopsessionreplayrecording 2.427 0.805 -1.622
startview 0.692 0.420 -0.272
logmessage 0.027 0.032 0.005
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 27.92 KiB 26.77 KiB -1181 B
addaction 52.04 KiB 50.51 KiB -1574 B
addtiming 26.71 KiB 26.12 KiB -605 B
adderror 56.38 KiB 55.84 KiB -557 B
startstopsessionreplayrecording 27.27 KiB 26.67 KiB -610 B
startview 413.59 KiB 412.36 KiB -1265 B
logmessage 55.72 KiB 53.78 KiB -1979 B

🔗 RealWorld

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/trace-context-injection-sampled branch from 60f617c to 0babc35 Compare December 12, 2024 09:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (7335202) to head (0babc35).

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #3212      +/-   ##
==========================================
- Coverage   93.52%   93.49%   -0.03%     
==========================================
  Files         285      285              
  Lines        7549     7549              
  Branches     1718     1718              
==========================================
- Hits         7060     7058       -2     
- Misses        489      491       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-lebeau thomas-lebeau marked this pull request as ready for review December 12, 2024 14:54
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner December 12, 2024 14:54
@thomas-lebeau thomas-lebeau merged commit 4a95777 into v6 Dec 16, 2024
17 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/trace-context-injection-sampled branch December 16, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants