✨ Support custom schema for Electron #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
seravifer
changed the title
|
@thomas-lebeau can you review this? |
|
@seravifer, thank you for your submission, we're having a look. |
thomas-lebeau
approved these changes
Dec 17, 2024
|
@seravifer, we require all commits to be signed, would you be able to fix this PR to have signed commits? Otherwise I could open a separate PR myself and pick you changes but we'll lose the commit attribution. |
|
@thomas-lebeau Done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support Electron apps when using custom schema.
#3131
Changes
Add new work to the regex that parses error URLs.
Testing
I have gone over the contributing documentation.