Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 CI - Enable yarn strategy on the repository #3079

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

NielkSalocin
Copy link
Contributor

@NielkSalocin NielkSalocin commented Oct 18, 2024

Motivation

Build Impact Analysis service supports indexing native yarn packages.
BIA integrates with the mergequeue, to enable parallel merge of prs that don't have any overlap in changed or impacted packages.
The "yarn strategy" is mature: it has been enabled in web-ui repository as well for several months, and used at scale to parallelize merges.
Other use cases can also consume this data (e.g. adding labels on every pull requests with the list of changed packages, viewing the dependency graph of a service)

Changes

Enable indexing the repository with yarn strategy.
This is a CI-only change, that should not impact this repository in any way visible to users (enabler for activation of new features in the future)

Testing

Visualisation of the dependency graph for browser-sdk package - link

@bits-bot
Copy link

bits-bot commented Oct 18, 2024

CLA assistant check
All committers have signed the CLA.

@NielkSalocin NielkSalocin changed the title CI - Enable yarn strategy on the repository 👷 CI - Enable yarn strategy on the repository Oct 18, 2024
@NielkSalocin NielkSalocin force-pushed the nklein/bia_enable_yarn_strategy branch from b70e94f to 1a0b5ca Compare October 18, 2024 09:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (ec70c12) to head (0e538f9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3079      +/-   ##
==========================================
+ Coverage   93.55%   93.66%   +0.11%     
==========================================
  Files         276      276              
  Lines        7628     7628              
  Branches     1712     1712              
==========================================
+ Hits         7136     7145       +9     
+ Misses        492      483       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NielkSalocin NielkSalocin marked this pull request as ready for review October 18, 2024 09:32
@NielkSalocin NielkSalocin requested a review from a team as a code owner October 18, 2024 09:32
Copy link

cit-pr-commenter bot commented Oct 18, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 0 B 161.36 KiB 161.36 KiB N/A%
Logs 0 B 56.07 KiB 56.07 KiB N/A%
Rum Slim 0 B 109.87 KiB 109.87 KiB N/A%
Worker 0 B 25.21 KiB 25.21 KiB N/A%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext N/A 0.001 0.001
addaction N/A 0.030 0.030
addtiming N/A 0.001 0.001
adderror N/A 0.030 0.030
startstopsessionreplayrecording N/A 0.827 0.827
startview 1.521 0.972 -0.549
logmessage N/A 0.019 0.019
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext NaN KiB 7.98 KiB NaN KiB
addaction NaN KiB 38.92 KiB NaN KiB
addtiming NaN KiB 6.16 KiB NaN KiB
adderror NaN KiB 43.85 KiB NaN KiB
startstopsessionreplayrecording NaN KiB 4.56 KiB NaN KiB
startview NaN KiB 465.69 KiB NaN KiB
logmessage NaN KiB 40.17 KiB NaN KiB

🔗 RealWorld

@NielkSalocin NielkSalocin force-pushed the nklein/bia_enable_yarn_strategy branch from 1a0b5ca to 0e538f9 Compare October 18, 2024 13:01
@BenoitZugmeyer BenoitZugmeyer merged commit 8bd1493 into main Oct 22, 2024
19 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the nklein/bia_enable_yarn_strategy branch October 22, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants