Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 Add SDK setup telemetry #3045

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Sep 27, 2024

Motivation

Add SDK setup to the telemetry events

Changes

telemetry: {
  sdk_setup: 'npm' | 'cdn'
}

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner September 27, 2024 12:02
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.56%. Comparing base (f6c9f43) to head (ede0006).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3045      +/-   ##
==========================================
- Coverage   93.66%   93.56%   -0.11%     
==========================================
  Files         275      275              
  Lines        7610     7610              
  Branches     1707     1707              
==========================================
- Hits         7128     7120       -8     
- Misses        482      490       +8     
Flag Coverage Δ
93.56% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amortemousque
Copy link
Collaborator Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Oct 1, 2024

🚂 Branch Integration: starting soon, median merge time is 0s

Commit ede0006561 will soon be integrated into staging-40.

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Oct 1, 2024
Integrated commit sha: ede0006

Co-authored-by: Aymeric Mortemousque <[email protected]>
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Oct 1, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit ede0006561 has been merged into staging-40 in merge commit 6a029d5c19.

Check out the triggered pipeline on Gitlab 🦊

@dd-devflow dd-devflow bot added the staging-40 label Oct 1, 2024
@amortemousque amortemousque merged commit cd768fe into main Oct 1, 2024
20 checks passed
@amortemousque amortemousque deleted the aymeric/add-cdn-npm-telemetry branch October 1, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants